Switch from text insertion to key press and release events on the virtual k…

ui/keyboard/resources/elements/kb-key-codes.html

 <!--
   -- Copyright 2013 The Chromium Authors. All rights reserved.
   -- Use of this source code is governed by a BSD-style license that can be
   -- found in the LICENSE file.
   -->
 
 <polymer-element name="kb-key-codes">
 <script>
   (function() {
+    // Each virtual key event is assigned a unique ID.
+    var nextRequestID = 0;
+
     // Keycodes have been deprecated in the KeyEvent specification, but are
     // nonetheless required to support legacy web content.  The Keycodes in the
     // following table are based on subset of US-EN 101-key keyboard. These
     // codes are used in the absence of explicit keycodes for kb-key and
     // kb-keysequence elements. Keyboard layout authors may explicitly set the
     // keyCode attribute for kb-key or kb-keysequence elements to refer to
     // indices in this table in order to emulate a physical keyboard with an
     // alternate layout.  Not all keys on a virtual keyboard are required to
     // have keyCodes.
     var keyCodes = {
@@ skipping 112 matching lines @@
           };
         }
         return {
           keyCode: 0,
           shiftModifier: false
         };
       },
 
      /**
       * Creates a virtual key event for use with the keyboard extension API.
-      * @param {kb-key} key Instance of the kb-key element being pressed or
-      *     released.
+      * See http://www.w3.org/TR/DOM-Level-3-Events/#events-KeyboardEvent.
+      * @param {Object} detail Attribute of the key being pressed or released.
       * @param {string} type The type of key event, which may be keydown
-      *     or keyreleased.
-      * @return {keyCode: numeric,
-      *          modifiers: Array.<string>,
-      *          type: string,
-      *          value: string}
+      *     or keyup.
+      * @return {?KeyboardEvent} A KeyboardEvent object, or undefined on
+      *     failure.
       */

[bshe, 2013/09/03 23:18:11]

function names should start with a lower case letter? Or it doesn't matter? My
understanding is that only function constructor starts with upper case. But I
may miss something from the style guide.

[kevers, 2013/09/04 13:51:20]

Yes, it should have been lowercase.  Fixed.

-     CreateVirtualKeyEvent: function(key, type) {
-       var keyCode = key.keyCode;
-       var shiftModifier = key.shiftModifier;
+     CreateVirtualKeyEvent: function(detail, type) {
+       var char = detail.char;
+       if (!char || char.length != 1) {
+         console.error('Invalid key. Expected single character.');
+         return;
+       }
+       var keyCode = detail.keyCode;
+       var shiftModifier = detail.shiftModifier;
        if (keyCode == undefined) {
-         var state = this.GetKeyCodeAndModifiers(key.charValue);
+         var state = this.GetKeyCodeAndModifiers(char);
+         if (state) {
          keyCode = state.keyCode;

[bshe, 2013/09/03 23:18:11]

nit: indent is off

[kevers, 2013/09/04 13:51:20]

Fixed.

          shiftModifier = state.shiftModifier;
+         } else {
+           keyCode = 0;
+           shiftModifier = false;
+         }
        }
-       var modifiers = [];
-       if (shiftModifier)
-         modifiers.push('shiftKey');
        return {
+         type: type,
+         charValue: char.charCodeAt(0),
          keyCode: keyCode,
-         modifiers: modifiers,
-         type: type,
-         value: key.charValue,
+         shiftKey: shiftModifier
        };
      },
     });
   })();
 </script>
 </polymer-element>