Switch from text insertion to key press and release events on the virtual k…

ui/keyboard/keyboard_ui_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/keyboard/keyboard_ui_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 11 matching lines @@
 namespace keyboard {
 
 KeyboardUIHandler::KeyboardUIHandler() {
 }
 
 KeyboardUIHandler::~KeyboardUIHandler() {
 }
 
 void KeyboardUIHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
       "insertText",

[sadrul, 2013/09/03 22:43:43]

Is 'insertText' used anymore? If both 'insertText' and 'sendKeyEvent' are
available, what are the differences between the two? If 'insertText' is not used
anymore, does it make sense to remove this code?

[kevers, 2013/09/04 13:51:20]

InsertText is still being used for multi-character buttons like ".com".  In this
case, we do not want the characters to be fed through IME where they could be
reinterpreted as part of a text composition.

[sadrul, 2013/09/04 15:44:54]

Ah, ok. Thanks for explaining.

       base::Bind(&KeyboardUIHandler::HandleInsertTextMessage,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "getInputContext",
       base::Bind(&KeyboardUIHandler::HandleGetInputContextMessage,
                  base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "sendKeyEvent",
+      base::Bind(&KeyboardUIHandler::HandleSendKeyEventMessage,
+                 base::Unretained(this)));
+
 }
 
 void KeyboardUIHandler::HandleInsertTextMessage(const base::ListValue* args) {
   string16 text;
   if (!args->GetString(0, &text)) {
     LOG(ERROR) << "insertText failed: bad argument";
     return;
   }
 
   aura::RootWindow* root_window =
@@ skipping 31 matching lines @@
   }
 
   ui::TextInputClient* tic = input_method->GetTextInputClient();
   results.SetInteger("type",
                      tic ? tic->GetTextInputType() : ui::TEXT_INPUT_TYPE_NONE);
 
   web_ui()->CallJavascriptFunction("GetInputContextCallback",
                                    results);
 }
 
+void KeyboardUIHandler::HandleSendKeyEventMessage(
+    const base::ListValue* args) {
+  const base::DictionaryValue* params = NULL;
+  std::string type;
+  int char_value;
+  int key_code;
+  bool shift_modifier;
+
+  if (!args->GetDictionary(0, &params) ||
+      !params->GetString("type", &type) ||
+      !params->GetInteger("charValue", &char_value) ||
+      !params->GetInteger("keyCode", &key_code) ||
+      !params->GetBoolean("shiftKey", &shift_modifier)) {
+    LOG(ERROR) << "SendKeyEvent failed: bad argument";
+    return;
+  }
+
+  aura::RootWindow* root_window =
+      web_ui()->GetWebContents()->GetView()->GetNativeView()->GetRootWindow();
+  if (!root_window) {
+    LOG(ERROR) << "sendKeyEvent failed: no root window";
+    return;
+  }
+
+  if (!keyboard::SendKeyEvent(type,
+                              char_value,
+                              key_code,
+                              shift_modifier,
+                              root_window)) {
+    LOG(ERROR) << "sendKeyEvent failed";
+  }
+}
+
 }  // namespace keyboard