Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: net/socket/transport_client_socket_unittest.cc

Issue 20142003: Remove ref-counting from StreamListenSocket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_listen_socket_unittest.cc ('k') | net/socket/unix_domain_socket_posix.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/transport_client_socket_unittest.cc
diff --git a/net/socket/transport_client_socket_unittest.cc b/net/socket/transport_client_socket_unittest.cc
index 9282c2019217e746667806126e418a80a1ca9a2d..5548b27b995999dc76daebc8d418230e4c4dace8 100644
--- a/net/socket/transport_client_socket_unittest.cc
+++ b/net/socket/transport_client_socket_unittest.cc
@@ -48,8 +48,9 @@ class TransportClientSocketTest
// Implement StreamListenSocket::Delegate methods
virtual void DidAccept(StreamListenSocket* server,
- StreamListenSocket* connection) OVERRIDE {
- connected_sock_ = reinterpret_cast<TCPListenSocket*>(connection);
+ scoped_ptr<StreamListenSocket> connection) OVERRIDE {
+ connected_sock_.reset(
+ static_cast<TCPListenSocket*>(connection.release()));
}
virtual void DidRead(StreamListenSocket*, const char* str, int len) OVERRIDE {
// TODO(dkegel): this might not be long enough to tickle some bugs.
@@ -65,7 +66,7 @@ class TransportClientSocketTest
void CloseServerSocket() {
// delete the connected_sock_, which will close it.
- connected_sock_ = NULL;
+ connected_sock_.reset();
}
void PauseServerReads() {
@@ -94,8 +95,8 @@ class TransportClientSocketTest
scoped_ptr<StreamSocket> sock_;
private:
- scoped_refptr<TCPListenSocket> listen_sock_;
- scoped_refptr<TCPListenSocket> connected_sock_;
+ scoped_ptr<TCPListenSocket> listen_sock_;
+ scoped_ptr<TCPListenSocket> connected_sock_;
bool close_server_socket_on_next_send_;
};
@@ -103,7 +104,7 @@ void TransportClientSocketTest::SetUp() {
::testing::TestWithParam<ClientSocketTestTypes>::SetUp();
// Find a free port to listen on
- scoped_refptr<TCPListenSocket> sock;
+ scoped_ptr<TCPListenSocket> sock;
int port;
// Range of ports to listen on. Shouldn't need to try many.
const int kMinPort = 10100;
@@ -117,7 +118,7 @@ void TransportClientSocketTest::SetUp() {
break;
}
ASSERT_TRUE(sock.get() != NULL);
- listen_sock_ = sock;
+ listen_sock_ = sock.Pass();
listen_port_ = port;
AddressList addr;
« no previous file with comments | « net/socket/tcp_listen_socket_unittest.cc ('k') | net/socket/unix_domain_socket_posix.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698