Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: net/socket/tcp_listen_socket_unittest.h

Issue 20142003: Remove ref-counting from StreamListenSocket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_listen_socket.cc ('k') | net/socket/tcp_listen_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_listen_socket_unittest.h
diff --git a/net/socket/tcp_listen_socket_unittest.h b/net/socket/tcp_listen_socket_unittest.h
index 93adbd58132b52e9ff5bed4be0ec0164b05d319c..1bc31a8d1ce0c8b501633ad8b4c4c5f56e390dd9 100644
--- a/net/socket/tcp_listen_socket_unittest.h
+++ b/net/socket/tcp_listen_socket_unittest.h
@@ -91,15 +91,15 @@ class TCPListenSocketTester :
// StreamListenSocket::Delegate:
virtual void DidAccept(StreamListenSocket* server,
- StreamListenSocket* connection) OVERRIDE;
+ scoped_ptr<StreamListenSocket> connection) OVERRIDE;
virtual void DidRead(StreamListenSocket* connection, const char* data,
int len) OVERRIDE;
virtual void DidClose(StreamListenSocket* sock) OVERRIDE;
scoped_ptr<base::Thread> thread_;
base::MessageLoopForIO* loop_;
- scoped_refptr<TCPListenSocket> server_;
- StreamListenSocket* connection_;
+ scoped_ptr<TCPListenSocket> server_;
+ scoped_ptr<StreamListenSocket> connection_;
TCPListenSocketTestAction last_action_;
SocketDescriptor test_socket_;
@@ -113,7 +113,7 @@ class TCPListenSocketTester :
virtual ~TCPListenSocketTester();
- virtual scoped_refptr<TCPListenSocket> DoListen();
+ virtual scoped_ptr<TCPListenSocket> DoListen();
// Getters/setters for |server_port_|. They use |lock_| for thread safety.
int GetServerPort();
« no previous file with comments | « net/socket/tcp_listen_socket.cc ('k') | net/socket/tcp_listen_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698