Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: net/server/http_server_unittest.cc

Issue 20142003: Remove ref-counting from StreamListenSocket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/server/http_server.cc ('k') | net/socket/stream_listen_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/server/http_server_unittest.cc
diff --git a/net/server/http_server_unittest.cc b/net/server/http_server_unittest.cc
index 48a2ce7571f6a38ac21c4feb17a32b47b61673f2..ede5066c3cdf92009cde96b9b0c45fc525c9388e 100644
--- a/net/server/http_server_unittest.cc
+++ b/net/server/http_server_unittest.cc
@@ -276,9 +276,9 @@ class MockStreamListenSocket : public StreamListenSocket {
} // namespace
TEST_F(HttpServerTest, RequestWithBodySplitAcrossPackets) {
- scoped_refptr<StreamListenSocket> socket(
- new MockStreamListenSocket(server_.get()));
- server_->DidAccept(NULL, socket.get());
+ StreamListenSocket* socket =
+ new MockStreamListenSocket(server_.get());
+ server_->DidAccept(NULL, make_scoped_ptr(socket));
std::string body("body");
std::string request = base::StringPrintf(
"GET /test HTTP/1.1\r\n"
@@ -286,9 +286,9 @@ TEST_F(HttpServerTest, RequestWithBodySplitAcrossPackets) {
"Content-Length: %" PRIuS "\r\n\r\n%s",
body.length(),
body.c_str());
- server_->DidRead(socket.get(), request.c_str(), request.length() - 2);
+ server_->DidRead(socket, request.c_str(), request.length() - 2);
ASSERT_EQ(0u, requests_.size());
- server_->DidRead(socket.get(), request.c_str() + request.length() - 2, 2);
+ server_->DidRead(socket, request.c_str() + request.length() - 2, 2);
ASSERT_EQ(1u, requests_.size());
ASSERT_EQ(body, requests_[0].data);
}
« no previous file with comments | « net/server/http_server.cc ('k') | net/socket/stream_listen_socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698