Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5597)

Unified Diff: chrome/browser/devtools/browser_list_tabcontents_provider.cc

Issue 20142003: Remove ref-counting from StreamListenSocket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/browser_list_tabcontents_provider.h ('k') | chrome_frame/test/test_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/browser_list_tabcontents_provider.cc
diff --git a/chrome/browser/devtools/browser_list_tabcontents_provider.cc b/chrome/browser/devtools/browser_list_tabcontents_provider.cc
index 41d7001f4d3f45588ae1a3c4b419da648e15662d..d4c76a8037b06c71ea43e91bd9a89380d8029d55 100644
--- a/chrome/browser/devtools/browser_list_tabcontents_provider.cc
+++ b/chrome/browser/devtools/browser_list_tabcontents_provider.cc
@@ -139,7 +139,7 @@ std::string BrowserListTabContentsProvider::GetViewDescription(
#if defined(DEBUG_DEVTOOLS)
static int g_last_tethering_port_ = 9333;
-scoped_refptr<net::StreamListenSocket>
+scoped_ptr<net::StreamListenSocket>
BrowserListTabContentsProvider::CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) {
@@ -147,13 +147,14 @@ BrowserListTabContentsProvider::CreateSocketForTethering(
g_last_tethering_port_ = 9333;
int port = ++g_last_tethering_port_;
*name = base::IntToString(port);
- return net::TCPListenSocket::CreateAndListen("127.0.0.1", port, delegate);
+ return net::TCPListenSocket::CreateAndListen("127.0.0.1", port, delegate)
+ .PassAs<StreamListenSocket>();
}
#else
-scoped_refptr<net::StreamListenSocket>
+scoped_ptr<net::StreamListenSocket>
BrowserListTabContentsProvider::CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) {
- return NULL;
+ return scoped_ptr<net::StreamListenSocket>();
}
#endif // defined(DEBUG_DEVTOOLS)
« no previous file with comments | « chrome/browser/devtools/browser_list_tabcontents_provider.h ('k') | chrome_frame/test/test_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698