Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: net/test/embedded_test_server/http_connection.h

Issue 20142003: Remove ref-counting from StreamListenSocket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_TEST_EMBEDDED_TEST_SERVER_HTTP_CONNECTION_H_ 5 #ifndef NET_TEST_EMBEDDED_TEST_SERVER_HTTP_CONNECTION_H_
6 #define NET_TEST_EMBEDDED_TEST_SERVER_HTTP_CONNECTION_H_ 6 #define NET_TEST_EMBEDDED_TEST_SERVER_HTTP_CONNECTION_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/memory/ref_counted.h"
11 #include "base/strings/string_piece.h" 10 #include "base/strings/string_piece.h"
12 #include "net/test/embedded_test_server/http_request.h" 11 #include "net/test/embedded_test_server/http_request.h"
13 12
14 namespace net { 13 namespace net {
15 14
16 class StreamListenSocket; 15 class StreamListenSocket;
17 16
18 namespace test_server { 17 namespace test_server {
19 18
20 class HttpConnection; 19 class HttpConnection;
21 class HttpResponse; 20 class HttpResponse;
22 21
23 // Calblack called when a request is parsed. Response should be sent 22 // Calblack called when a request is parsed. Response should be sent
24 // using HttpConnection::SendResponse() on the |connection| argument. 23 // using HttpConnection::SendResponse() on the |connection| argument.
25 typedef base::Callback<void(HttpConnection* connection, 24 typedef base::Callback<void(HttpConnection* connection,
26 scoped_ptr<HttpRequest> request)> 25 scoped_ptr<HttpRequest> request)>
27 HandleRequestCallback; 26 HandleRequestCallback;
28 27
29 // Wraps the connection socket. Accepts incoming data and sends responses. 28 // Wraps the connection socket. Accepts incoming data and sends responses.
30 // If a valid request is parsed, then |callback_| is invoked. 29 // If a valid request is parsed, then |callback_| is invoked.
31 class HttpConnection { 30 class HttpConnection {
32 public: 31 public:
33 HttpConnection(StreamListenSocket* socket, 32 HttpConnection(scoped_ptr<StreamListenSocket> socket,
34 const HandleRequestCallback& callback); 33 const HandleRequestCallback& callback);
35 ~HttpConnection(); 34 ~HttpConnection();
36 35
37 // Sends the HTTP response to the client. 36 // Sends the HTTP response to the client.
38 void SendResponse(scoped_ptr<HttpResponse> response) const; 37 void SendResponse(scoped_ptr<HttpResponse> response) const;
39 38
40 private: 39 private:
41 friend class EmbeddedTestServer; 40 friend class EmbeddedTestServer;
42 41
43 // Accepts raw chunk of data from the client. Internally, passes it to the 42 // Accepts raw chunk of data from the client. Internally, passes it to the
44 // HttpRequestParser class. If a request is parsed, then |callback_| is 43 // HttpRequestParser class. If a request is parsed, then |callback_| is
45 // called. 44 // called.
46 void ReceiveData(const base::StringPiece& data); 45 void ReceiveData(const base::StringPiece& data);
47 46
48 scoped_refptr<StreamListenSocket> socket_; 47 scoped_ptr<StreamListenSocket> socket_;
49 const HandleRequestCallback callback_; 48 const HandleRequestCallback callback_;
50 HttpRequestParser request_parser_; 49 HttpRequestParser request_parser_;
51 50
52 DISALLOW_COPY_AND_ASSIGN(HttpConnection); 51 DISALLOW_COPY_AND_ASSIGN(HttpConnection);
53 }; 52 };
54 53
55 } // namespace test_server 54 } // namespace test_server
56 } // namespace net 55 } // namespace net
57 56
58 #endif // NET_TEST_EMBEDDED_TEST_SERVER_HTTP_CONNECTION_H_ 57 #endif // NET_TEST_EMBEDDED_TEST_SERVER_HTTP_CONNECTION_H_
OLDNEW
« no previous file with comments | « net/test/embedded_test_server/embedded_test_server.cc ('k') | net/test/embedded_test_server/http_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698