✈ Remove unnecessary flag and DocumentModeManager.

chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
 import android.content.SharedPreferences;
-import android.os.Build;
 import android.test.suitebuilder.annotation.MediumTest;
 import android.view.View;
 
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.ContextUtils;
 import org.chromium.base.ThreadUtils;
-import org.chromium.base.test.util.CommandLineFlags;
-import org.chromium.base.test.util.DisabledTest;
-import org.chromium.base.test.util.MinAndroidSdkLevel;
-import org.chromium.base.test.util.Restriction;
 import org.chromium.base.test.util.UrlUtils;
 import org.chromium.blink_public.platform.WebDisplayMode;
 import org.chromium.chrome.browser.ChromeActivity;
-import org.chromium.chrome.browser.ChromeSwitches;
 import org.chromium.chrome.browser.ChromeTabbedActivity;
 import org.chromium.chrome.browser.ShortcutHelper;
 import org.chromium.chrome.browser.ShortcutSource;
-import org.chromium.chrome.browser.document.DocumentActivity;
-import org.chromium.chrome.browser.preferences.DocumentModeManager;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tab.TabIdManager;
 import org.chromium.chrome.test.MultiActivityTestBase;
 import org.chromium.chrome.test.util.ActivityUtils;
 import org.chromium.chrome.test.util.ApplicationTestUtils;
-import org.chromium.chrome.test.util.ChromeRestriction;
 import org.chromium.chrome.test.util.browser.TabLoadObserver;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
 import org.chromium.content.browser.test.util.JavaScriptUtils;
 import org.chromium.content.browser.test.util.TouchCommon;
 import org.chromium.content_public.common.ScreenOrientationValues;
 
 /**
  * Tests that WebappActivities are launched correctly.
  *
@@ skipping 171 matching lines @@
      * Ensure WebappActivities can't be launched without proper security checks.
      */
     @MediumTest
     public void testWebappRequiresValidMac() throws Exception {
         // Try to start a WebappActivity.  Fail because the Intent is insecure.
         fireWebappIntent(WEBAPP_1_ID, WEBAPP_1_URL, WEBAPP_1_TITLE, WEBAPP_ICON, false);
         CriteriaHelper.pollUiThread(new Criteria() {
             @Override
             public boolean isSatisfied() {
                 Activity lastActivity = ApplicationStatus.getLastTrackedFocusedActivity();
-                return lastActivity instanceof ChromeTabbedActivity
-                        || lastActivity instanceof DocumentActivity;
+                return lastActivity instanceof ChromeTabbedActivity;
             }
         });
         ChromeActivity chromeActivity =
                 (ChromeActivity) ApplicationStatus.getLastTrackedFocusedActivity();
         waitForFullLoad(chromeActivity, WEBAPP_1_TITLE);
 
         // Firing a correct Intent should start a WebappActivity instance instead of the browser.
         fireWebappIntent(WEBAPP_2_ID, WEBAPP_2_URL, WEBAPP_2_TITLE, WEBAPP_ICON, true);
         CriteriaHelper.pollUiThread(new Criteria() {
             @Override
             public boolean isSatisfied() {
                 return isWebappActivityReady(ApplicationStatus.getLastTrackedFocusedActivity());
             }
         });
     }
 
     /**
-     * Tests that WebappActivities handle window.open() properly in document mode.
-     */
-    @MinAndroidSdkLevel(Build.VERSION_CODES.LOLLIPOP)
-    @Restriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
-    @DisabledTest
-    public void testWebappHandlesWindowOpenInDocumentMode() throws Exception {
-        triggerWindowOpenAndWaitForDocumentLoad(ONCLICK_LINK, true);
-    }
-
-    /**
      * Tests that WebappActivities handle window.open() properly in tabbed mode.
      */
-    @CommandLineFlags.Add(ChromeSwitches.DISABLE_DOCUMENT_MODE)
     @MediumTest
     public void testWebappHandlesWindowOpenInTabbedMode() throws Exception {
         triggerWindowOpenAndWaitForLoad(ChromeTabbedActivity.class, ONCLICK_LINK, true);
     }
 
     /**
-     * Tests that WebappActivities handle suppressed window.open() properly in document mode.
-     */
-    @MinAndroidSdkLevel(Build.VERSION_CODES.LOLLIPOP)
-    @Restriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
-    @DisabledTest
-    public void testWebappHandlesSuppressedWindowOpenInDocumentMode() throws Exception {
-        triggerWindowOpenAndWaitForDocumentLoad(HREF_NO_REFERRER_LINK, false);
-    }
-
-    /**
      * Tests that WebappActivities handle suppressed window.open() properly in tabbed mode.
      */
-    @CommandLineFlags.Add(ChromeSwitches.DISABLE_DOCUMENT_MODE)
     @MediumTest
     public void testWebappHandlesSuppressedWindowOpenInTabbedMode() throws Exception {
         triggerWindowOpenAndWaitForLoad(ChromeTabbedActivity.class, HREF_NO_REFERRER_LINK, false);
     }
 
-    private void triggerWindowOpenAndWaitForDocumentLoad(
-            String linkHtml, boolean checkContents) throws Exception {
-        // We default to tabbed mode. To have the WebappActivity launch a DocumentActivity,
-        // we have to explicitly override that default here.
-        DocumentModeManager documentModeManager = DocumentModeManager.getInstance(
-                getInstrumentation().getTargetContext());
-        boolean previouslyOptedOut = documentModeManager.isOptedOutOfDocumentMode();
-        documentModeManager.setOptedOutState(DocumentModeManager.OPT_OUT_PROMO_DISMISSED);
-        try {
-            triggerWindowOpenAndWaitForLoad(DocumentActivity.class, linkHtml, checkContents);
-        } finally {
-            if (previouslyOptedOut) {
-                documentModeManager.setOptedOutState(
-                        DocumentModeManager.OPTED_OUT_OF_DOCUMENT_MODE);
-            }
-        }
-    }
-
     private <T extends ChromeActivity> void triggerWindowOpenAndWaitForLoad(
             Class<T> classToWaitFor, String linkHtml, boolean checkContents) throws Exception {
         final WebappActivity firstActivity =
                 startWebappActivity(WEBAPP_1_ID, WEBAPP_1_URL, WEBAPP_1_TITLE, WEBAPP_ICON);
         final int firstWebappId = firstActivity.getActivityTab().getId();
 
         // Load up the test page.
         new TabLoadObserver(firstActivity.getActivityTab()).fullyLoadUrl(linkHtml);
 
         // Do a plain click to make the link open in the main browser via a window.open().
@@ skipping 61 matching lines @@
 
         WebappActivity webappActivity = (WebappActivity) lastActivity;
         if (webappActivity.getActivityTab() == null) return false;
 
         View rootView = webappActivity.findViewById(android.R.id.content);
         if (!rootView.hasWindowFocus()) return false;
 
         return true;
     }
 }