Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2013723002: Consider ClipPathDisplayItems for GPU veto. (Closed)

Created:
4 years, 7 months ago by f(malita)
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, Stephen White
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, bsalomon_chromium, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, reed1, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consider ClipPathDisplayItems for GPU veto. Based on senorblanco's investigation, we currently don't veto complex clipPaths. Building on top of http://crrev.com/2000423005, refactor DisplayItem GPU veto to also feed ClipPathDisplayItem signals into SkPictureGpuAnalyzer. BUG=603969 R=chrishtr@chromium.org,senorblanco@chromium.org Committed: https://crrev.com/c64bd21780da13051846ae45b54a1e6c6bf6ac52 Cr-Commit-Position: refs/heads/master@{#396232}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : unit test #

Patch Set 4 : fix unit test asserts #

Messages

Total messages: 12 (6 generated)
f(malita)
4 years, 7 months ago (2016-05-26 15:14:10 UTC) #3
chrishtr
lgtm
4 years, 7 months ago (2016-05-26 16:09:59 UTC) #4
Stephen White
LGTM Excited to see the perf impact!
4 years, 7 months ago (2016-05-26 16:18:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013723002/60001
4 years, 7 months ago (2016-05-26 16:53:43 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-26 18:17:15 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:19:21 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c64bd21780da13051846ae45b54a1e6c6bf6ac52
Cr-Commit-Position: refs/heads/master@{#396232}

Powered by Google App Engine
This is Rietveld 408576698