Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201363002: DevTools: defer styles delta calculation to until the end of the task. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, alph+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, Inactive, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, rwlbuis
Visibility:
Public.

Description

DevTools: defer styles delta calculation to until the end of the task. BUG=289708 R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169371

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Total comments: 1

Patch Set 5 : Same with debugger support. #

Patch Set 6 : Restored original test expectations. #

Patch Set 7 : Audits panel test fixed #

Patch Set 8 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -87 lines) Patch
M LayoutTests/http/tests/inspector/elements/styles/edit-css-with-source-url.html View 1 2 3 4 5 2 chunks +4 lines, -7 lines 0 comments Download
M LayoutTests/inspector/audits/audits-panel-functional-expected.txt View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/add-new-rule-with-style-after-body.html View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/dynamic-style-tag.html View 1 2 chunks +13 lines, -12 lines 0 comments Download
M LayoutTests/inspector/elements/styles/dynamic-style-tag-expected.txt View 1 2 chunks +26 lines, -26 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-test.js View 1 2 3 4 5 6 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.cpp View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 6 chunks +21 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorController.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 1 2 3 4 5 6 6 chunks +17 lines, -15 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 4 3 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
pfeldman
6 years, 9 months ago (2014-03-17 06:19:02 UTC) #1
aandrey
https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorController.cpp File Source/core/inspector/InspectorController.cpp (right): https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorController.cpp#newcode154 Source/core/inspector/InspectorController.cpp:154: m_cssAgent = cssAgentPtr.get(); never used
6 years, 9 months ago (2014-03-17 06:45:17 UTC) #2
lushnikov
https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorCSSAgent.cpp#newcode575 Source/core/inspector/InspectorCSSAgent.cpp:575: if (m_creatingViaInspectorStyleSheet) I don't see where you set this ...
6 years, 9 months ago (2014-03-17 08:37:31 UTC) #3
lushnikov
https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorCSSAgent.cpp#newcode566 Source/core/inspector/InspectorCSSAgent.cpp:566: m_invalidatedDocuments.swap(&invalidatedDocuments); This is nifty; but why not simply clear ...
6 years, 9 months ago (2014-03-17 08:46:43 UTC) #4
lushnikov
https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorController.cpp File Source/core/inspector/InspectorController.cpp (right): https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorController.cpp#newcode153 Source/core/inspector/InspectorController.cpp:153: OwnPtr<InspectorCSSAgent> cssAgentPtr(InspectorCSSAgent::create(m_domAgent, m_pageAgent, resourceAgent)); looks like all this change ...
6 years, 9 months ago (2014-03-17 08:59:33 UTC) #5
pfeldman
PTAL should work by debugging modulus. https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://codereview.chromium.org/201363002/diff/20001/Source/core/inspector/InspectorCSSAgent.cpp#newcode566 Source/core/inspector/InspectorCSSAgent.cpp:566: m_invalidatedDocuments.swap(&invalidatedDocuments); On 2014/03/17 ...
6 years, 9 months ago (2014-03-17 12:32:57 UTC) #6
vsevik
https://chromiumcodereview.appspot.com/201363002/diff/40001/Source/web/WebDevToolsAgentImpl.cpp File Source/web/WebDevToolsAgentImpl.cpp (right): https://chromiumcodereview.appspot.com/201363002/diff/40001/Source/web/WebDevToolsAgentImpl.cpp#newcode620 Source/web/WebDevToolsAgentImpl.cpp:620: if (m_attached) remove https://chromiumcodereview.appspot.com/201363002/diff/50001/Source/core/inspector/InspectorCSSAgent.cpp File Source/core/inspector/InspectorCSSAgent.cpp (right): https://chromiumcodereview.appspot.com/201363002/diff/50001/Source/core/inspector/InspectorCSSAgent.cpp#newcode918 Source/core/inspector/InspectorCSSAgent.cpp:918: ...
6 years, 9 months ago (2014-03-17 12:49:27 UTC) #7
vsevik
lgtm
6 years, 9 months ago (2014-03-17 15:33:35 UTC) #8
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-17 15:36:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/201363002/90001
6 years, 9 months ago (2014-03-17 15:37:02 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 15:39:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-17 15:39:54 UTC) #12
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-17 17:00:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/201363002/100001
6 years, 9 months ago (2014-03-17 17:00:58 UTC) #14
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-17 17:05:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/201363002/110001
6 years, 9 months ago (2014-03-17 17:05:27 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 17:25:27 UTC) #17
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-17 17:25:28 UTC) #18
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-17 17:43:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/201363002/110001
6 years, 9 months ago (2014-03-17 17:43:32 UTC) #20
pfeldman
6 years, 9 months ago (2014-03-17 17:59:09 UTC) #21
Message was sent while issue was closed. 
Committed patchset #8 manually as r169371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698