Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: media/base/video_decoder.h

Issue 20136002: Reland r212023 "Rename VideoDecoder::ReadCB to VideoDecoder::DecodeCB." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix content_browsertests failure. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mock_filters.h ('k') | media/filters/decrypting_video_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index d10dd2fed103205a67f1b7bc15b8645c96d864cf..63f63e5d7d6d9b70dc9f84c98fb159b2e7653df5 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -55,13 +55,12 @@ class MEDIA_EXPORT VideoDecoder {
// - NULL frame indicates an aborted decode. This can happen if Reset() or
// Stop() is called during the decoding process.
// Otherwise the returned frame must be NULL.
- //
- // TODO(xhwang): Rename this to DecodeCB.
- typedef base::Callback<void(Status, const scoped_refptr<VideoFrame>&)> ReadCB;
+ typedef base::Callback<void(Status,
+ const scoped_refptr<VideoFrame>&)> DecodeCB;
virtual void Decode(const scoped_refptr<DecoderBuffer>& buffer,
- const ReadCB& read_cb) = 0;
+ const DecodeCB& decode_cb) = 0;
- // Resets decoder state, fulfilling all pending ReadCB and dropping extra
+ // Resets decoder state, fulfilling all pending DecodeCB and dropping extra
// queued decoded data. After this call, the decoder is back to an initialized
// clean state.
// Note: No VideoDecoder calls should be made before |closure| is executed.
« no previous file with comments | « media/base/mock_filters.h ('k') | media/filters/decrypting_video_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698