Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 20136002: Reland r212023 "Rename VideoDecoder::ReadCB to VideoDecoder::DecodeCB." (Closed)

Created:
7 years, 5 months ago by xhwang
Modified:
7 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Reland r212023 "Rename VideoDecoder::ReadCB to VideoDecoder::DecodeCB." This reverts r212147 and relands r212023. The original CL (r212023) changed the behavior of VideoRendererBase so that if a video frame read is aborted, we report a PIPELINE_ERROR_ABORT. This CL reverts this change and keeps the behavior the same as before. BUG=261305, 141788 TEST=content_browsertest works without flakiness on Linux. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213888

Patch Set 1 #

Patch Set 2 : fix content_browsertests failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -149 lines) Patch
M media/base/mock_filters.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_decoder.h View 1 chunk +4 lines, -5 lines 0 comments Download
M media/filters/decrypting_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 11 chunks +23 lines, -23 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/fake_video_decoder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 12 chunks +21 lines, -21 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 7 chunks +20 lines, -19 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 4 chunks +4 lines, -7 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 10 chunks +18 lines, -17 lines 0 comments Download
M media/filters/video_frame_stream.h View 4 chunks +14 lines, -4 lines 0 comments Download
M media/filters/video_frame_stream.cc View 7 chunks +17 lines, -11 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M media/filters/video_renderer_base.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/video_renderer_base.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M media/filters/video_renderer_base_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 6 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xhwang
Patch set 1 is the original CL (rebased). Patch set 2 has the fix to ...
7 years, 5 months ago (2013-07-24 21:33:24 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 5 months ago (2013-07-24 22:09:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/20136002/2001
7 years, 5 months ago (2013-07-24 23:01:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/20136002/2001
7 years, 5 months ago (2013-07-25 14:39:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/20136002/2001
7 years, 5 months ago (2013-07-26 02:25:59 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 13:36:34 UTC) #6
Message was sent while issue was closed.
Change committed as 213888

Powered by Google App Engine
This is Rietveld 408576698