Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: Source/heap/Handle.h

Issue 20123003: [oilpan] The Node hierarchy should have correct accept method chains (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/WebVTTElement.cpp ('k') | Source/heap/Visitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/heap/Handle.h
diff --git a/Source/heap/Handle.h b/Source/heap/Handle.h
index 9078c47ad434e401194a2e4ddeeb3b5ad3a05c92..4cbc6873f40fa3d5ec3ffad4f8962f461b631b9a 100644
--- a/Source/heap/Handle.h
+++ b/Source/heap/Handle.h
@@ -762,17 +762,6 @@ public:
return releaseRaw() ? &Result::m_raw : 0;
}
- // FIXME(oilpan): Make this private.
- T* releaseRaw() const
- {
- T* raw = m_raw;
- m_raw = 0;
-#ifndef NDEBUG
- m_doNotAllocate.release();
-#endif
- return raw;
- }
-
// FIXME(oilpan): Remove once TreeShared no longer requires reference counting.
PassRefPtr<T> passRefPtr() const
{
@@ -788,6 +777,16 @@ private:
{
}
+ T* releaseRaw() const
+ {
+ T* raw = m_raw;
+ m_raw = 0;
+#ifndef NDEBUG
+ m_doNotAllocate.release();
+#endif
+ return raw;
+ }
+
// Mutable to allow raw() to steal the pointer when creating a
// Handle from the Result.
mutable T* m_raw;
@@ -963,6 +962,12 @@ public:
}
template<typename U>
+ bool operator!=(const Handle<U>& other) const
+ {
+ return other.raw() != raw();
+ }
+
+ template<typename U>
bool operator==(const Persistent<U>& other) const
{
return other.raw() == raw();
« no previous file with comments | « Source/core/html/track/WebVTTElement.cpp ('k') | Source/heap/Visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698