impl/memory/datastore_test.go - Issue 2011773002: datastore: variadic Get, Put, Exists, Delete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/memory/datastore_test.go

Issue 2011773002: datastore: variadic Get, Put, Exists, Delete. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: impl/memory/datastore_test.go

diff --git a/impl/memory/datastore_test.go b/impl/memory/datastore_test.go

index 3b9f91e212dfc2f75d09512216539fc0785e295e..c78d9c3700e1538c257a69c46a0c85fbfebfbc7e 100644

--- a/impl/memory/datastore_test.go

+++ b/impl/memory/datastore_test.go

@@ -99,7 +99,7 @@ func TestDatastoreSingleReadWriter(t *testing.T) {

for i := range keys {

keys[i] = ds.MakeKey(aid, "noexist", "Kind", i+1)

}

- So(ds.DeleteMulti(keys), ShouldBeNil)

+ So(ds.DeleteMulti(keys...), ShouldBeNil)

count := 0

So(ds.Raw().DeleteMulti(keys, func(err error) error {

count++

@@ -126,7 +126,7 @@ func TestDatastoreSingleReadWriter(t *testing.T) {

}

Convey("ensure that group versions persist across deletes", func() {

- So(ds.DeleteMulti(append(keys, k)), ShouldBeNil)

+ So(ds.DeleteMulti(append(keys, k)...), ShouldBeNil)

ds.Testable().CatchupIndexes()

« no previous file with comments | « impl/memory/datastore_query_execution_test.go ('k') | service/datastore/datastore.go » ('j') | service/datastore/datastore.go » ('J')