Source/core/css/resolver/FontBuilder.cpp - Issue 20112002: Have const StyleResolverState return const RenderStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/FontBuilder.cpp

Issue 20112002: Have const StyleResolverState return const RenderStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/FontBuilder.cpp

diff --git a/Source/core/css/resolver/FontBuilder.cpp b/Source/core/css/resolver/FontBuilder.cpp

index 8eb357329d4dafee0575a797759405f68d2c7bfd..487470f14cb43334ff06348d28c248a7ed4842c4 100644

--- a/Source/core/css/resolver/FontBuilder.cpp

+++ b/Source/core/css/resolver/FontBuilder.cpp

@@ -281,7 +281,7 @@ static float smallerFontSize(float size)

}

// FIXME: Have to pass RenderStyles here for calc/computed values. This shouldn't be neecessary.

-void FontBuilder::setFontSizeValue(CSSValue* value, RenderStyle* parentStyle, RenderStyle* rootElementStyle, float effectiveZoom)

+void FontBuilder::setFontSizeValue(CSSValue* value, RenderStyle* parentStyle, const RenderStyle* rootElementStyle, float effectiveZoom)

{

if (!value->isPrimitiveValue())

return;