Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1683)

Issue 2010993003: Revert of Temporarily enable hang report capture (Closed)

Created:
4 years, 7 months ago by manzagop (departed)
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporarily enable hang report capture (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/1986233002/ ) Reason for revert: Single day experiment. Original issue's description: > Temporarily enable hang report capture > > Overview: > Browser process hangs are believed to be responsible for a large > fraction of browser unclean shutdowns on Windows. This patch enables > hang report capture to get visibility into the problem. > > Note: > - This is a follow up to a previous ship: https://codereview.chromium.org/1891563002/ > - Capture only occurs on canary Chrome for users with stats consent. > - The plan is to release for a single day. > > BUG=478209, 585953 > > Committed: https://crrev.com/bdfbf2514ead1bf337613ac79864f021c5e6e737 > Cr-Commit-Position: refs/heads/master@{#395970} TBR=pmonette@chromium.org,dpranke@google.com,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478209, 585953 Committed: https://crrev.com/3e1394151512d59ce1c5041becc3ab268623e709 Cr-Commit-Position: refs/heads/master@{#396170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/kasko/kasko.gni View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
manzagop (departed)
Created Revert of Temporarily enable hang report capture
4 years, 7 months ago (2016-05-26 13:10:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010993003/1
4 years, 7 months ago (2016-05-26 13:10:45 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-26 13:10:47 UTC) #4
Sigurður Ásgeirsson
lgtm
4 years, 7 months ago (2016-05-26 14:02:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010993003/1
4 years, 7 months ago (2016-05-26 14:02:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 14:02:57 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 14:04:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e1394151512d59ce1c5041becc3ab268623e709
Cr-Commit-Position: refs/heads/master@{#396170}

Powered by Google App Engine
This is Rietveld 408576698