Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 20106002: Correct bit-shift in IPC hash generation. (Closed)

Created:
7 years, 5 months ago by dsinclair
Modified:
7 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Correct bit-shift in IPC hash generation. The actual bit shifting that happens does not match what is specified in the comment. With the current implementation we will shift the PID over 14 bits, this sets the top 22 bits with the bottom 22 bits of the PID. When then OR the count with 0x3fff giving us 14 bits which we shift over 8 bits. This will end up OR'ing 8 bits of the count with 8 bits of the PID. Instead, we shift the PID over 22 bits, giving is 10 bits of the PID and shift the 14 bits of the count over 8. There should be no OR'ing between the PID and the count. This then matches what is specified in the comments. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/ipc_message.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dsinclair
nduca, PTAL.
7 years, 5 months ago (2013-07-24 19:44:59 UTC) #1
nduca
lgtm
7 years, 5 months ago (2013-07-24 20:03:54 UTC) #2
nduca
+cpu for OWNERS
7 years, 5 months ago (2013-07-24 20:04:36 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
7 years, 5 months ago (2013-07-24 22:01:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/20106002/1
7 years, 5 months ago (2013-07-25 00:52:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/20106002/1
7 years, 5 months ago (2013-07-25 14:25:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/20106002/1
7 years, 5 months ago (2013-07-26 02:12:25 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 13:17:13 UTC) #8
Message was sent while issue was closed.
Change committed as 213882

Powered by Google App Engine
This is Rietveld 408576698