Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20104005: enable MSE and legacy EME by default on Android (Closed)

Created:
7 years, 5 months ago by qinmin
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

enable MSE and legacy EME by default on Android We are planning to launch MSE and clearkey/EME for M30 on android. This CL will enable MSE and clearkey/EME for android. Launch bug: BUG=233420, 263679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213881

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -55 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -16 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/runtime_features.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
qinmin
PTAL
7 years, 5 months ago (2013-07-24 21:52:31 UTC) #1
xhwang
lgtm % nit https://codereview.chromium.org/20104005/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/20104005/diff/1/content/public/common/content_switches.cc#newcode389 content/public/common/content_switches.cc:389: // Disable prefixed Media Source API ...
7 years, 5 months ago (2013-07-24 22:22:34 UTC) #2
xhwang
Please also update CL title to specify that this is for Android.
7 years, 5 months ago (2013-07-24 22:23:09 UTC) #3
qinmin
https://codereview.chromium.org/20104005/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/20104005/diff/1/content/public/common/content_switches.cc#newcode389 content/public/common/content_switches.cc:389: // Disable prefixed Media Source API (i.e., the WebKitMediaSource ...
7 years, 5 months ago (2013-07-24 22:32:42 UTC) #4
jam
lgtm
7 years, 5 months ago (2013-07-24 22:53:40 UTC) #5
scherkus (not reviewing)
lgtm
7 years, 5 months ago (2013-07-24 23:00:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/20104005/6001
7 years, 5 months ago (2013-07-24 23:26:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/20104005/6001
7 years, 5 months ago (2013-07-25 14:23:00 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-25 18:00:30 UTC) #9
acolwell GONE FROM CHROMIUM
lgtm
7 years, 5 months ago (2013-07-25 18:21:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/20104005/30001
7 years, 5 months ago (2013-07-25 19:38:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/20104005/30001
7 years, 5 months ago (2013-07-26 02:10:21 UTC) #12
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 13:16:52 UTC) #13
Message was sent while issue was closed. 
Change committed as 213881

Powered by Google App Engine
This is Rietveld 408576698