|
|
Created:
4 years, 7 months ago by anatoly techtonik Modified:
4 years, 7 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionFix depot_tools\git.bat when depot_tools in not in PATH
R=iannucci@chromium.org, dpranke@chromium.org
BUG=
Patch Set 1 #
Messages
Total messages: 18 (3 generated)
Why would depot_tools need to be in the path for this? What git command will invoke a non-git depot_tools command?
On 2016/05/25 15:46:17, Dirk Pranke (slow) wrote: > Why would depot_tools need to be in the path for this? What git command will > invoke a non-git depot_tools command? git cl
On 2016/05/25 16:11:21, anatoly techtonik wrote: > On 2016/05/25 15:46:17, Dirk Pranke (slow) wrote: > > Why would depot_tools need to be in the path for this? What git command will > > invoke a non-git depot_tools command? > > git cl Good example :). lgtm.
The CQ bit was checked by techtonik@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009173002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
I guess it is linefeed problem.
On 2016/05/25 18:52:17, anatoly techtonik wrote: > I guess it is linefeed problem. Yes this is a newline issue.
iannucci@chromium.org changed reviewers: + phajdan.jr@chromium.org
I'm not sure how we can commit this without someone taking over this CL :/ Pawel, do you know of a way that we can CQ this? Otherwise I can land this on your behalf Anatoly.
On 2016/05/25 20:41:36, iannucci wrote: > I'm not sure how we can commit this without someone taking over this CL :/ > > Pawel, do you know of a way that we can CQ this? Otherwise I can land this on > your behalf Anatoly. Sounds like I'll have to land this. I'll do this now.
On 2016/05/25 20:46:00, iannucci wrote: > On 2016/05/25 20:41:36, iannucci wrote: > > I'm not sure how we can commit this without someone taking over this CL :/ > > > > Pawel, do you know of a way that we can CQ this? Otherwise I can land this on > > your behalf Anatoly. > > Sounds like I'll have to land this. I'll do this now. Thanks. Probably .bat files need an exception from depot_tools Git config.
Message was sent while issue was closed.
closing in favor of https://codereview.chromium.org/2015673002/
Message was sent while issue was closed.
I think that this will get better when we switch to gerrit, where there's no more text patch files.
Message was sent while issue was closed.
On 2016/05/25 20:49:33, iannucci wrote: > I think that this will get better when we switch to gerrit, where there's no > more text patch files. And how does Gerrit handles that? Does it rely on some internal git changeset object? |