courgette/courgette.gyp - Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/courgette.gyp

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rollback to original courgette algorithm and improve unittests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: courgette/courgette.gyp

diff --git a/courgette/courgette.gyp b/courgette/courgette.gyp

index 88f2e2b92d649bad86d5598dcaa630eafb57b287..aa670149b9f02b1d48ab2a450425d93f5e58ccbf 100644

--- a/courgette/courgette.gyp

+++ b/courgette/courgette.gyp

@@ -45,8 +45,12 @@

'program_detector.cc',

'program_detector.h',

'region.h',

- 'rel32_finder_win32_x86.cc',

- 'rel32_finder_win32_x86.h',

+ 'rel32_finder.cc',

+ 'rel32_finder.h',

+ 'rel32_finder_x64.cc',

+ 'rel32_finder_x64.h',

+ 'rel32_finder_x86.cc',

+ 'rel32_finder_x86.h',

'simple_delta.cc',

'simple_delta.h',

'streams.cc',

@@ -120,7 +124,7 @@

'image_utils_unittest.cc',

'label_manager_unittest.cc',

'memory_allocator_unittest.cc',

- 'rel32_finder_win32_x86_unittest.cc',

+ 'rel32_finder_unittest.cc',

'streams_unittest.cc',

'typedrva_unittest.cc',

'versioning_unittest.cc',

« no previous file with comments | « courgette/BUILD.gn ('k') | courgette/disassembler_win32_x64.cc » ('j') | courgette/rel32_finder.h » ('J')