Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: courgette/testdata/rel32_x64_02.txt

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include processor type in test files and NIT Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/testdata/rel32_x64_02.txt
diff --git a/courgette/testdata/rel32_win32_x86_02.txt b/courgette/testdata/rel32_x64_02.txt
similarity index 60%
copy from courgette/testdata/rel32_win32_x86_02.txt
copy to courgette/testdata/rel32_x64_02.txt
index a9e5b1283d7f674088c00d2682dd496e71a7140d..b9e3757f58a14020cf4a6f09b91f8c8c3632f237 100644
--- a/courgette/testdata/rel32_win32_x86_02.txt
+++ b/courgette/testdata/rel32_x64_02.txt
@@ -1,5 +1,7 @@
# Test rel32 jump instructions with abs32 and .reloc obstructions.
+# Processor type
+x64
# .text start RVA and end RVA
1000
3000
@@ -34,8 +36,30 @@ Program:
0040105B: 0F 8D 00 00 00 00 jge 00401061 # Overlaps with abs32
00401061: 0F 8E 00 00 00 00 jle 00401067
00401067: 0F 8F 00 00 00 00 jg 0040106D
- 0040106D: 5D pop ebp
- 0040106E: C3 ret
+ 0040106D: FF 15 00 00 00 00 call 00401073
huangs 2016/05/30 18:14:48 Indirect, RIP-relative calls
etiennep 2016/06/01 17:23:40 Done.
+ 00401073: FF 25 00 00 00 00 jmp 00401079
+ 00401079: 8B 05 00 00 00 00 mov eax, [rip+00000000]
+ 0040107F: 8B 3D 00 00 00 00 mov edi, [rip+00000000]
+ 00401085: 8D 05 00 00 00 00 lea eax, [rip+00000000]
+ 0040108B: 8D 3D 00 00 00 00 lea edi, [rip+00000000]
+ 00401091: 48 8B 05 00 00 00 mov rax, [rip+00000000]
+ 00
+ 00401098: 48 8B 3D 00 00 00 mov rdi, [rip+00000000]
+ 00
+ 0040109F: 48 8D 05 00 00 00 lea rax, [rip+00000000]
+ 00
+ 004010A6: 48 8D 3D 00 00 00 lea rdi, [rip+00000000]
+ 00
+ 004010AD: 4C 8B 05 00 00 00 mov r8, [rip+00000000]
+ 00
+ 004010B4: 4C 8B 3D 00 00 00 mov r15, [rip+00000000]
+ 00
+ 004010BB: 4C 8D 05 00 00 00 lea r8, [rip+00000000]
+ 00
+ 004010C2: 4C 8D 3D 00 00 00 lea r15, [rip+00000000]
+ 00
+ 004010C9: 5D pop ebp
+ 004010CA: C3 ret
Abs32:
1004
@@ -58,5 +82,19 @@ Expected:
1045
# 1057
# 105D
-1063 # Op code 0F 8E overlaps with abs32 105F, but still okay
+1063
1069
+106F
+1075
+# 107B Not yet detected.
+# 1081 Not yet detected.
+# 1087 Not yet detected.
+# 108D Not yet detected.
+1094
+109B
+10A2
+10A9
+10B0
+10B7
huangs 2016/05/30 18:14:47 # 10B7
etiennep 2016/06/01 17:23:40 Done.
+10BE
+10C5

Powered by Google App Engine
This is Rietveld 408576698