Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: courgette/assembly_program.cc

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/assembly_program.cc
diff --git a/courgette/assembly_program.cc b/courgette/assembly_program.cc
index f20ed67ea3fa3e6a462f7d99e49153b7eec3d22c..f49d5e59c365d4d1336be7fe2c7b966b9a5bff43 100644
--- a/courgette/assembly_program.cc
+++ b/courgette/assembly_program.cc
@@ -406,7 +406,7 @@ std::unique_ptr<EncodedProgram> AssemblyProgram::Encode() const {
return nullptr;
break;
}
- case REL32ARM: {
+ /*case REL32ARM: {
huangs 2016/05/26 18:34:34 Not sure what this is about?
etiennep 2016/05/26 20:50:09 Whoops, no relation. Took it off.
Label* label =
static_cast<InstructionWithLabelARM*>(instruction)->label();
uint16_t compressed_op =
@@ -414,7 +414,7 @@ std::unique_ptr<EncodedProgram> AssemblyProgram::Encode() const {
if (!encoded->AddRel32ARM(compressed_op, label->index_))
return nullptr;
break;
- }
+ }*/
case ABS32: {
Label* label = static_cast<InstructionWithLabel*>(instruction)->label();
if (!encoded->AddAbs32(label->index_))
« no previous file with comments | « courgette/BUILD.gn ('k') | courgette/courgette.gyp » ('j') | courgette/encode_decode_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698