courgette/testdata/rel32_x86_02.txt - Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: courgette/testdata/rel32_x86_02.txt

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rollback to original courgette algorithm and improve unittests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Test rel32 jump instructions with abs32 and .reloc obstructions.	1 # Test rel32 jump instructions with abs32 and .reloc obstructions.

2	2

3 # .text start RVA and end RVA	3 # .text start RVA and end RVA

4 1000	4 1000

5 3000	5 3000

6 # .reloc start RVA and end RVA	6 # .reloc start RVA and end RVA

7 # Typically this won't overlap with .text.	7 # Typically this won't overlap with .text.

8 # Note: If we use 1020, then the algorithm would never encounter it, so the	8 # Note: If we use 1020, then the algorithm would never encounter it, so the

9 # .reloc does not get skipped! This edge case is not worth fixing right now.	9 # .reloc does not get skipped! This edge case is not worth fixing right now.

10 101F	10 101F

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 # 1027	53 # 1027

54 # 102D	54 # 102D

55 1033	55 1033

56 1039	56 1039

57 103F	57 103F

58 1045	58 1045

59 # 1057	59 # 1057

60 # 105D	60 # 105D

61 1063 # Op code 0F 8E overlaps with abs32 105F, but still okay	61 1063 # Op code 0F 8E overlaps with abs32 105F, but still okay

62 1069	62 1069

OLD	NEW

« courgette/testdata/rel32_x64_03.txt ('K') | « courgette/testdata/rel32_x86_01.txt ('k') | courgette/testdata/rel32_x86_03.txt » ('j') | no next file with comments »