Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h

Issue 2008233002: Add ReloadPageLoadMetricsObserver to have a metrics variant for reloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #7, #8 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..add024694ba60ec3f7f58eb7cd06a51c4883d827
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h
@@ -0,0 +1,37 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RELOAD_PAGE_LOAD_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RELOAD_PAGE_LOAD_METRICS_OBSERVER_H_
+
+#include "base/macros.h"
+#include "components/page_load_metrics/browser/page_load_metrics_observer.h"
+
+namespace chrome {
+
+// An observer class to report metrics on pages those loading were initiated
+// by one of reload operations including hitting enter in the omnibox.
+// This ignore JavaScript-initiated loadings by location.reload() or
+// history.go(0).
+class ReloadPageLoadMetricsObserver
+ : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+ ReloadPageLoadMetricsObserver();
+
+ // page_load_metrics::PageLoadMetricsObserver implementation:
+ void OnCommit(content::NavigationHandle* navigation_handle) override;
+ void OnFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+
+ private:
+ bool page_transition_was_reload_;
+ bool initiated_by_user_gesture_;
+
+ DISALLOW_COPY_AND_ASSIGN(ReloadPageLoadMetricsObserver);
+};
+
+} // namespace chrome
+
+#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_RELOAD_PAGE_LOAD_METRICS_OBSERVER_H_
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698