Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: media/base/null_video_sink_unittest.cc

Issue 2007463005: Paint first frame faster, don't crash with no frames during EOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Whoops, fix comment. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/null_video_sink.cc ('k') | media/base/video_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/null_video_sink_unittest.cc
diff --git a/media/base/null_video_sink_unittest.cc b/media/base/null_video_sink_unittest.cc
index aa0603be7ba6567af87801ae419e06ff5bb67b07..4fc5ed7296647343c4fef256f70d2b4b89884dcf 100644
--- a/media/base/null_video_sink_unittest.cc
+++ b/media/base/null_video_sink_unittest.cc
@@ -72,10 +72,6 @@ TEST_F(NullVideoSinkTest, BasicFunctionality) {
std::unique_ptr<NullVideoSink> sink = ConstructSink(false, kInterval);
scoped_refptr<VideoFrame> test_frame = CreateFrame(base::TimeDelta());
- // The sink shouldn't have to be started to use the paint method.
- EXPECT_CALL(*this, FrameReceived(test_frame));
- sink->PaintSingleFrame(test_frame);
-
{
SCOPED_TRACE("Waiting for sink startup.");
sink->Start(this);
@@ -115,6 +111,10 @@ TEST_F(NullVideoSinkTest, BasicFunctionality) {
sink->Stop();
event.RunAndWait();
}
+
+ // The sink shouldn't have to be started to use the paint method.
+ EXPECT_CALL(*this, FrameReceived(test_frame));
+ sink->PaintSingleFrame(test_frame);
}
TEST_F(NullVideoSinkTest, ClocklessFunctionality) {
« no previous file with comments | « media/base/null_video_sink.cc ('k') | media/base/video_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698