[Android Buildbot] Add option to run only host driven Python tests.

[Android Buildbot] Add option to run only host driven Python tests.

BUG=263624
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213558

[Yaron, 2013-07-23 23:45:36]

https://chromiumcodereview.appspot.com/20073002/diff/1/build/android/pylib/ba...
File build/android/pylib/base/test_dispatcher.py (left):

https://chromiumcodereview.appspot.com/20073002/diff/1/build/android/pylib/ba...
build/android/pylib/base/test_dispatcher.py:367: return
(base_test_result.TestRunResults(), constants.ERROR_EXIT_CODE)
Sorry for not being specific. While I'm fine with this (I'll leave approval to
Frank), I think it'd generally be preferable to fail if we have no python tests
AND no java tests. If we're missing one or the other, then it shouldn't be an
error.

[frankf, 2013-07-23 23:49:30]

On 2013/07/23 23:45:36, Yaron wrote:
>
https://chromiumcodereview.appspot.com/20073002/diff/1/build/android/pylib/ba...
> File build/android/pylib/base/test_dispatcher.py (left):
> 
>
https://chromiumcodereview.appspot.com/20073002/diff/1/build/android/pylib/ba...
> build/android/pylib/base/test_dispatcher.py:367: return
> (base_test_result.TestRunResults(), constants.ERROR_EXIT_CODE)
> Sorry for not being specific. While I'm fine with this (I'll leave approval to
> Frank), I think it'd generally be preferable to fail if we have no python
tests
> AND no java tests. If we're missing one or the other, then it shouldn't be an
> error.

You can supply -p to only run host-driven tests, which is probably what you want
here.

[Siva Chandra, 2013-07-23 23:51:45]

On 2013/07/23 23:49:30, frankf wrote:
> On 2013/07/23 23:45:36, Yaron wrote:
> >
>
https://chromiumcodereview.appspot.com/20073002/diff/1/build/android/pylib/ba...
> > File build/android/pylib/base/test_dispatcher.py (left):
> > 
> >
>
https://chromiumcodereview.appspot.com/20073002/diff/1/build/android/pylib/ba...
> > build/android/pylib/base/test_dispatcher.py:367: return
> > (base_test_result.TestRunResults(), constants.ERROR_EXIT_CODE)
> > Sorry for not being specific. While I'm fine with this (I'll leave approval
to
> > Frank), I think it'd generally be preferable to fail if we have no python
> tests
> > AND no java tests. If we're missing one or the other, then it shouldn't be
an
> > error.
> 
> You can supply -p to only run host-driven tests, which is probably what you
want
> here.

Given an annotation and exclude annotation, we will in general not be sure if we
have only host-driven tests.

[Siva Chandra, 2013-07-23 23:53:14]

On 2013/07/23 23:45:36, Yaron wrote:
>
https://chromiumcodereview.appspot.com/20073002/diff/1/build/android/pylib/ba...
> File build/android/pylib/base/test_dispatcher.py (left):
> 
>
https://chromiumcodereview.appspot.com/20073002/diff/1/build/android/pylib/ba...
> build/android/pylib/base/test_dispatcher.py:367: return
> (base_test_result.TestRunResults(), constants.ERROR_EXIT_CODE)
> Sorry for not being specific. While I'm fine with this (I'll leave approval to
> Frank), I think it'd generally be preferable to fail if we have no python
tests
> AND no java tests. If we're missing one or the other, then it shouldn't be an
> error.

While I agree, I took the faster route here as the code setup does not readily
allow to check if python tests as well as java tests are missing.

[frankf, 2013-07-24 00:10:01]

Just chatted with nyquist. Sync instrumentation tests already run on other bots
as part of SmallTest:

https://code.google.com/p/chromium/codesearch#chromium/src/sync/android/javat...


No need to rerun these again. So sync bot should only run the host-driven tests
with -p.

[Siva Chandra, 2013-07-24 00:29:23]

PTaL at patch set 2.

[frankf, 2013-07-24 00:36:23]

lgtm

[Siva Chandra, 2013-07-24 00:42:18]

On 2013/07/24 00:29:23, Siva Chandra wrote:
> PTaL at patch set 2.

While I made this CL, to my eyes, it is not clear if -p is actually honored
while running instrumentation tests. I am assuming frankf@, who has more insight
into the code, is correct.

[Yaron, 2013-07-24 19:01:23]

lgtm

[commit-bot: I haz the power, 2013-07-24 19:11:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sivachandra@chromium.org/20073002/4002

[commit-bot: I haz the power, 2013-07-24 23:09:46]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-07-24 23:23:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sivachandra@chromium.org/20073002/4002

[commit-bot: I haz the power, 2013-07-25 00:24:01]

Change committed as 213558