service/datastore/checkfilter.go - Issue 2007123002: datastore: Update AllocateIDs to take keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/checkfilter.go

Issue 2007123002: datastore: Update AllocateIDs to take keys. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Add empty arg/key short-circuits for other varidic methods. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: service/datastore/checkfilter.go

diff --git a/service/datastore/checkfilter.go b/service/datastore/checkfilter.go

index fe9bc57f99f3a3ea52e7f8d232b5de783e33090b..2e5616a969604ac5856df609ef7ea003a1fa85b4 100644

--- a/service/datastore/checkfilter.go

+++ b/service/datastore/checkfilter.go

@@ -19,16 +19,6 @@ type checkFilter struct {

ns string

}

-func (tcf *checkFilter) AllocateIDs(incomplete *Key, n int) (start int64, err error) {

- if n <= 0 {

- return 0, fmt.Errorf("datastore: invalid `n` parameter in AllocateIDs: %d", n)

- }

- if !incomplete.PartialValid(tcf.aid, tcf.ns) {

- return 0, ErrInvalidKey

- }

- return tcf.RawInterface.AllocateIDs(incomplete, n)

func (tcf *checkFilter) RunInTransaction(f func(c context.Context) error, opts *TransactionOptions) error {

if f == nil {

return fmt.Errorf("datastore: RunInTransaction function is nil")

« impl/memory/datastore_data.go ('K') | « impl/prod/raw_datastore.go ('k') | service/datastore/checkfilter_test.go » ('j') | service/datastore/interface.go » ('J')