Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: impl/prod/everything_test.go

Issue 2007123002: datastore: Update AllocateIDs to take keys. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Add empty arg/key short-circuits for other varidic methods. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: impl/prod/everything_test.go
diff --git a/impl/prod/everything_test.go b/impl/prod/everything_test.go
index 66a372d0c419d26b3ef72112abe778e098be1ca0..a761cdfff4a4375b07c5dd820fee77e8a92d38ee 100644
--- a/impl/prod/everything_test.go
+++ b/impl/prod/everything_test.go
@@ -68,11 +68,18 @@ func TestBasicDatastore(t *testing.T) {
})
Convey("Can probe/change Namespace", func() {
- So(inf.GetNamespace(), ShouldEqual, "")
+ ns, has := inf.GetNamespace()
+ So(ns, ShouldEqual, "")
+ So(has, ShouldBeFalse)
+
ctx, err = inf.Namespace("wat")
So(err, ShouldBeNil)
inf = info.Get(ctx)
- So(inf.GetNamespace(), ShouldEqual, "wat")
+
+ ns, has = inf.GetNamespace()
+ So(ns, ShouldEqual, "wat")
+ So(has, ShouldBeTrue)
+
ds = datastore.Get(ctx)
So(ds.MakeKey("Hello", "world").Namespace(), ShouldEqual, "wat")
})

Powered by Google App Engine
This is Rietveld 408576698