filter/count/rds.go - Issue 2007123002: datastore: Update AllocateIDs to take keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: filter/count/rds.go

Issue 2007123002: datastore: Update AllocateIDs to take keys. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Add empty arg/key short-circuits for other varidic methods. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: filter/count/rds.go

diff --git a/filter/count/rds.go b/filter/count/rds.go

index 69e903aea911634fca022ddd4881380048793255..8021f99020957162b21dcfe7f35e2ced2b9281dd 100644

--- a/filter/count/rds.go

+++ b/filter/count/rds.go

@@ -30,9 +30,8 @@ type dsCounter struct {

var _ ds.RawInterface = (*dsCounter)(nil)

-func (r *dsCounter) AllocateIDs(incomplete *ds.Key, n int) (int64, error) {

- start, err := r.ds.AllocateIDs(incomplete, n)

- return start, r.c.AllocateIDs.up(err)

+func (r *dsCounter) AllocateIDs(keys []*ds.Key, cb ds.PutMultiCB) error {

+ return r.c.AllocateIDs.up(r.ds.AllocateIDs(keys, cb))

}

func (r *dsCounter) DecodeCursor(s string) (ds.Cursor, error) {

« no previous file with comments | « no previous file | filter/featureBreaker/rds.go » ('j') | impl/memory/datastore_data.go » ('J')