Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20066005: DevTools: [Timeline] Reset Memory Overview pane when clear button is clicked (Closed)

Created:
7 years, 5 months ago by Pan
Modified:
7 years, 5 months ago
Reviewers:
caseq, eustas, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: [Timeline] Reset Memory Overview pane when clear button is clicked Contributed by pan.deng@intel.com BUG=263683 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154975

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove blank line #

Total comments: 1

Patch Set 3 : remove redundant _clear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M Source/devtools/front_end/TimelineOverviewPane.js View 1 2 3 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Pan
@caseq and Pavel, ready to review :) thanks! Pan
7 years, 5 months ago (2013-07-24 02:52:40 UTC) #1
eustas
https://codereview.chromium.org/20066005/diff/1/Source/devtools/front_end/TimelineOverviewPane.js File Source/devtools/front_end/TimelineOverviewPane.js (right): https://codereview.chromium.org/20066005/diff/1/Source/devtools/front_end/TimelineOverviewPane.js#newcode499 Source/devtools/front_end/TimelineOverviewPane.js:499: Remove second empty line, please.
7 years, 5 months ago (2013-07-24 06:08:20 UTC) #2
Pan
On 2013/07/24 06:08:20, eustas.ru wrote: > https://codereview.chromium.org/20066005/diff/1/Source/devtools/front_end/TimelineOverviewPane.js > File Source/devtools/front_end/TimelineOverviewPane.js (right): > > https://codereview.chromium.org/20066005/diff/1/Source/devtools/front_end/TimelineOverviewPane.js#newcode499 > ...
7 years, 5 months ago (2013-07-24 06:47:26 UTC) #3
caseq
https://codereview.chromium.org/20066005/diff/4001/Source/devtools/front_end/TimelineOverviewPane.js File Source/devtools/front_end/TimelineOverviewPane.js (right): https://codereview.chromium.org/20066005/diff/4001/Source/devtools/front_end/TimelineOverviewPane.js#newcode469 Source/devtools/front_end/TimelineOverviewPane.js:469: this._clear(ctx); Why do we need _clear() at all? Seems ...
7 years, 5 months ago (2013-07-24 09:07:05 UTC) #4
Pan
On 2013/07/24 09:07:05, caseq wrote: > https://codereview.chromium.org/20066005/diff/4001/Source/devtools/front_end/TimelineOverviewPane.js > File Source/devtools/front_end/TimelineOverviewPane.js (right): > > https://codereview.chromium.org/20066005/diff/4001/Source/devtools/front_end/TimelineOverviewPane.js#newcode469 > ...
7 years, 5 months ago (2013-07-25 01:30:30 UTC) #5
caseq
On 2013/07/25 01:30:30, Pan wrote: > done, :) lgtm
7 years, 5 months ago (2013-07-25 06:18:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/20066005/8001
7 years, 5 months ago (2013-07-26 02:53:13 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 05:10:42 UTC) #8
Message was sent while issue was closed. 
Change committed as 154975

Powered by Google App Engine
This is Rietveld 408576698