Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: apps/app_shim/app_shim_host_manager_mac.mm

Issue 20065004: Make AppShimHostManager a RefCountedThreadSafe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comment Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/app_shim/app_shim_host_manager_mac.h ('k') | chrome/browser/browser_process_platform_part_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/app_shim/app_shim_host_manager_mac.mm
diff --git a/apps/app_shim/app_shim_host_manager_mac.mm b/apps/app_shim/app_shim_host_manager_mac.mm
index 049ba5b4fea07c95f2aa1be57c92da73f51bd18c..c364c1a6a05a366da293be71e9b1416f106d5908 100644
--- a/apps/app_shim/app_shim_host_manager_mac.mm
+++ b/apps/app_shim/app_shim_host_manager_mac.mm
@@ -31,8 +31,7 @@ AppShimHostManager::AppShimHostManager() {
apps::AppShimHandler::SetDefaultHandler(&extension_app_shim_handler_);
BrowserThread::PostTask(
tapted 2013/09/09 21:48:36 Ah, so since reference counts start from zero, thi
BrowserThread::FILE, FROM_HERE,
- base::Bind(&AppShimHostManager::InitOnFileThread,
- base::Unretained(this)));
+ base::Bind(&AppShimHostManager::InitOnFileThread, this));
}
AppShimHostManager::~AppShimHostManager() {
@@ -52,8 +51,7 @@ void AppShimHostManager::InitOnFileThread() {
factory_.reset(new IPC::ChannelFactory(socket_path, this));
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- base::Bind(&AppShimHostManager::ListenOnIOThread,
- base::Unretained(this)));
+ base::Bind(&AppShimHostManager::ListenOnIOThread, this));
}
void AppShimHostManager::ListenOnIOThread() {
« no previous file with comments | « apps/app_shim/app_shim_host_manager_mac.h ('k') | chrome/browser/browser_process_platform_part_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698