Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 20056003: Moves calling OnAutoHideState to when exactly the state has changed (2nd) (Closed)

Created:
7 years, 5 months ago by Jun Mukai
Modified:
7 years, 5 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Moves calling OnAutoHideState to when exactly the state has changed (2nd) This method is called when a window is maximized or fullscreen. The first attempt was reverted due to a test failure in LauncherTooltipManagerTest, and it turns out that's because the observer method is not emitted correctly. BUG=249509 TBR=harrym@chromium.org, jamescook@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M ash/shelf/shelf_layout_manager.cc View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jun Mukai
submitting with TBR since this is a reland with a small fix
7 years, 5 months ago (2013-07-23 20:20:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/20056003/1
7 years, 5 months ago (2013-07-23 20:21:23 UTC) #2
James Cook
lgtm
7 years, 5 months ago (2013-07-24 00:24:31 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 00:38:11 UTC) #4
Message was sent while issue was closed.
Change committed as 213298

Powered by Google App Engine
This is Rietveld 408576698