Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 20051004: created common nav bar in footer, changed send feedback link (Closed)

Created:
7 years, 5 months ago by mem
Modified:
7 years, 5 months ago
Reviewers:
Kathy Walrath
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

created common nav bar in footer, changed send feedback link BUG= R=kathyw@google.com Committed: 91b4789

Patch Set 1 #

Patch Set 2 : new send feedback links for KW, + moved nav stuff to common footer #

Total comments: 2

Patch Set 3 : non-breaking spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -237 lines) Patch
src/site/_includes/tutorial.html View 1 2 2 chunks +30 lines, -9 lines 0 comments Download
src/site/_includes/tutorial-main-page.html View 1 2 2 chunks +30 lines, -9 lines 0 comments Download
src/site/docs/tutorials/add-elements/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download
src/site/docs/tutorials/connect-dart-html/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download
src/site/docs/tutorials/custom-elements/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download
src/site/docs/tutorials/fetchdata/index.markdown View 1 2 4 chunks +6 lines, -20 lines 0 comments Download
src/site/docs/tutorials/forms/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download
src/site/docs/tutorials/get-started/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download
src/site/docs/tutorials/index.markdown View 2 chunks +3 lines, -18 lines 0 comments Download
src/site/docs/tutorials/indexeddb/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download
src/site/docs/tutorials/packages/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download
src/site/docs/tutorials/remove-elements/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download
src/site/docs/tutorials/templates/index.markdown View 2 chunks +4 lines, -19 lines 0 comments Download
src/site/docs/tutorials/web-ui/index.markdown View 2 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mem
7 years, 5 months ago (2013-07-23 19:03:59 UTC) #1
Kathy Walrath
lgtm! I noticed a couple of things you could change, but in general this looks ...
7 years, 5 months ago (2013-07-23 21:31:05 UTC) #2
mem
http://newfeedbacklink.dart-lang.appspot.com/docs/tutorials/ + fixed other resources in T9 mem https://chromiumcodereview.appspot.com/20051004/diff/1001/src/site/_includes/tutorial.html File src/site/_includes/tutorial.html (right): https://chromiumcodereview.appspot.com/20051004/diff/1001/src/site/_includes/tutorial.html#newcode96 src/site/_includes/tutorial.html:96: <a ...
7 years, 5 months ago (2013-07-23 23:07:00 UTC) #3
Kathy Walrath
Whoa, the diffs are misbehaving right now. E.g. https://chromiumcodereview.appspot.com/20051004/diff2/1001:6001/src/site/docs/tutorials/fetchdata/index.markdown shows almost everything being deleted. As ...
7 years, 5 months ago (2013-07-23 23:27:14 UTC) #4
Kathy Walrath
lgtm The staged version looks good, so we'll assume rietveld is just being stupid.
7 years, 5 months ago (2013-07-23 23:42:23 UTC) #5
mem
7 years, 5 months ago (2013-07-23 23:44:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r91b4789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698