Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java

Issue 2005053002: WebAPKs: Open links which are outside of WebAPK scope in Chrome not in WebAPK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java
index d056d36f58c498ba557ef6bf7e878d21acb09151..403bfbce4a5cf7f43811ef324cf20363e65f4bde 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java
@@ -43,6 +43,9 @@ public class ExternalNavigationParams {
/** Whether this navigation happens in main frame. */
private final boolean mIsMainFrame;
+ /** Whether this navigation happens in a WebAPK. */
+ private final boolean mIsWebApk;
+
/** Whether this navigation is launched by user gesture. */
private final boolean mHasUserGesture;
@@ -55,7 +58,8 @@ public class ExternalNavigationParams {
private ExternalNavigationParams(String url, boolean isIncognito, String referrerUrl,
int pageTransition, boolean isRedirect, boolean appMustBeInForeground,
TabRedirectHandler redirectHandler, Tab tab, boolean openInNewTab,
- boolean isBackgroundTabNavigation, boolean isMainFrame, boolean hasUserGesture,
+ boolean isBackgroundTabNavigation, boolean isMainFrame, boolean isWebApk,
+ boolean hasUserGesture,
boolean shouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent) {
mUrl = url;
mIsIncognito = isIncognito;
@@ -68,6 +72,7 @@ public class ExternalNavigationParams {
mOpenInNewTab = openInNewTab;
mIsBackgroundTabNavigation = isBackgroundTabNavigation;
mIsMainFrame = isMainFrame;
+ mIsWebApk = isWebApk;
mHasUserGesture = hasUserGesture;
mShouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent =
shouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent;
@@ -131,6 +136,11 @@ public class ExternalNavigationParams {
return mIsMainFrame;
}
+ /** @return Whether this navigation happens in a WebAPK. */
+ public boolean isWebApk() {
+ return mIsWebApk;
+ }
+
/** @return Whether this navigation is launched by user gesture. */
public boolean hasUserGesture() {
return mHasUserGesture;
@@ -178,6 +188,9 @@ public class ExternalNavigationParams {
/** Whether this navigation happens in main frame. */
private boolean mIsMainFrame;
+ /** Whether this navigation happens in a WebAPK. */
+ private boolean mIsWebApk;
+
/** Whether this navigation is launched by user gesture. */
private boolean mHasUserGesture;
@@ -237,6 +250,12 @@ public class ExternalNavigationParams {
return this;
}
+ /** Sets whether this navigation happens in a WebAPK. */
+ public Builder setIsWebApk(boolean v) {
+ mIsWebApk = v;
+ return this;
+ }
+
/** Sets whether this navigation happens in main frame. */
public Builder setHasUserGesture(boolean v) {
mHasUserGesture = v;
@@ -254,8 +273,8 @@ public class ExternalNavigationParams {
/** @return A fully constructed {@link ExternalNavigationParams} object. */
public ExternalNavigationParams build() {
return new ExternalNavigationParams(mUrl, mIsIncognito, mReferrerUrl, mPageTransition,
- mIsRedirect, mApplicationMustBeInForeground, mRedirectHandler,
- mTab, mOpenInNewTab, mIsBackgroundTabNavigation, mIsMainFrame,
+ mIsRedirect, mApplicationMustBeInForeground, mRedirectHandler, mTab,
+ mOpenInNewTab, mIsBackgroundTabNavigation, mIsMainFrame, mIsWebApk,
mHasUserGesture, mShouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent);
}
}

Powered by Google App Engine
This is Rietveld 408576698