runtime/vm/intermediate_language_x64.cc - Issue 2003403003: ARM/ARM64: Fix smashed CODE_REG in intrinsics with InvokeMathCFunctionInstrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 2003403003: ARM/ARM64: Fix smashed CODE_REG in intrinsics with InvokeMathCFunctionInstrs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_x64.cc

diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc

index 9f87ca9873bfe48a4150676fe99328dd54cdf423..4760a1a2f5dad28f62ece819cfc5019dfe4df8bf 100644

--- a/runtime/vm/intermediate_language_x64.cc

+++ b/runtime/vm/intermediate_language_x64.cc

@@ -5186,6 +5186,7 @@ LocationSummary* InvokeMathCFunctionInstr::MakeLocationSummary(Zone* zone,

(recognized_kind() == MethodRecognizer::kMathDoublePow) ? 3 : 1;

LocationSummary* result = new(zone) LocationSummary(

zone, InputCount(), kNumTemps, LocationSummary::kCall);

+ COMPILE_ASSERT(R13 != CALLEE_SAVED_TEMP);

result->set_temp(0, Location::RegisterLocation(R13));

Vyacheslav Egorov (Google) 2016/05/25 11:15:31 This needs an assertion somewhere that R13 is call

rmacnak 2016/05/25 16:58:51 Done.

result->set_in(0, Location::FpuRegisterLocation(XMM2));

if (InputCount() == 2) {

« no previous file with comments | « runtime/vm/constants_x64.h ('k') | runtime/vm/intrinsifier_arm.cc » ('j') | runtime/vm/intrinsifier_arm.cc » ('J')