Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4426)

Unified Diff: chrome/browser/android/tab_android.cc

Issue 2002433002: Handle online and offline redirects via interceptor and offline scheme (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index efd00c4aaab7e2cf4591d60c291f952945b7cf13..cabe2385e711aebaf0e8d6e04026ca74f7b57acf 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -801,7 +801,7 @@ jboolean TabAndroid::IsOfflinePage(JNIEnv* env,
const JavaParamRef<jobject>& obj) {
GURL url = dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(
web_contents()->GetURL());
- return offline_pages::OfflinePageUtils::IsOfflinePage(GetProfile(), url);
+ return url.SchemeIs(chrome::kOfflinePageScheme);
}
ScopedJavaLocalRef<jstring> TabAndroid::GetOfflinePageOriginalUrl(
@@ -809,10 +809,10 @@ ScopedJavaLocalRef<jstring> TabAndroid::GetOfflinePageOriginalUrl(
const JavaParamRef<jobject>& obj) {
GURL url = dom_distiller::url_utils::GetOriginalUrlFromDistillerUrl(
web_contents()->GetURL());
- GURL original_url =
- offline_pages::OfflinePageUtils::MaybeGetOnlineURLForOfflineURL(
- GetProfile(), url);
- if (!original_url.is_valid())
+ if (!url.SchemeIs(chrome::kOfflinePageScheme))
+ return ScopedJavaLocalRef<jstring>();
+ GURL original_url(url.GetContent());
+ if (!original_url.is_valid() || !original_url.SchemeIsHTTPOrHTTPS())
return ScopedJavaLocalRef<jstring>();
return ScopedJavaLocalRef<jstring>(
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_tab_helper.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698