ash/common/shelf/shelf_constants.cc - Issue 2002293002: Use vector icon for Ash shelf launcher

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/shelf/shelf_constants.cc

Issue 2002293002: Use vector icon for Ash shelf launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add arc support, include .icon files Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/common/shelf/shelf_constants.h"	5 #include "ash/common/shelf/shelf_constants.h"

6	6

7 namespace ash {	7 namespace ash {

8	8

9 const int kShelfBackgroundAlpha = 204;	9 const int kShelfBackgroundAlpha = 204;

10 const int kInvalidImageResourceID = -1;	10 const int kInvalidImageResourceID = -1;

11 const int kShelfSize = 47;	11 const int kShelfSize = 47;

12 const int kShelfButtonSpacing = 10;	12 const int kShelfButtonSpacing = 10;

13 const int kShelfButtonSize = 44;	13 const int kShelfButtonSize = 44;

14 const int kTimeToSwitchBackgroundMs = 1000;	14 const int kTimeToSwitchBackgroundMs = 1000;

15	15

	16 const SkColor kShelfIconColor = SK_ColorWHITE;
	James Cook 2016/06/07 15:51:52 nit: Either no blank line above, for consistency, nit: Either no blank line above, for consistency, or space them all out. tdanderson 2016/06/08 17:29:27 Done. Show quoted text On 2016/06/07 15:51:52, James Cook wrote: > nit: Either no blank line above, for consistency, or space them all out. Done.
	17

16 } // namespace ash	18 } // namespace ash

OLD	NEW