Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 20022002: Make adb_profile_chrome work on OSX (Closed)

Created:
7 years, 5 months ago by pdr.
Modified:
7 years, 5 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Make adb_profile_chrome work on OSX adb_profile_chrome relies on regular expression matching to pull the correct trace file from the device. Unfortunatey, OSX ships with a version of sed from 2005 which doesn't support matching of newline characters (see http://www.culmination.org/2008/02/sed-on-mac-os-x-105-leopard/). This patch switches to perl, making adb_profile_chrome work on OSX. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/adb_profile_chrome View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
pdr.
7 years, 5 months ago (2013-07-23 04:12:25 UTC) #1
nduca
+wangxianzhu, overlord of android tracingses
7 years, 5 months ago (2013-07-23 04:13:09 UTC) #2
klobag.chromium
Xianzhu is on vacation. Have you tried on Linux?
7 years, 5 months ago (2013-07-23 05:42:29 UTC) #3
pdr.
On 2013/07/23 05:42:29, klobag.chromium wrote: > Xianzhu is on vacation. > > Have you tried ...
7 years, 5 months ago (2013-07-23 05:44:13 UTC) #4
pdr.
On 2013/07/23 05:44:13, pdr wrote: > On 2013/07/23 05:42:29, klobag.chromium wrote: > > Xianzhu is ...
7 years, 5 months ago (2013-07-23 19:24:24 UTC) #5
klobag.chromium
lgtm thanks
7 years, 5 months ago (2013-07-23 19:50:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/20022002/1
7 years, 5 months ago (2013-07-23 21:30:32 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_tests, nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=179039
7 years, 5 months ago (2013-07-24 05:00:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/20022002/1
7 years, 5 months ago (2013-07-24 05:18:46 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 11:05:15 UTC) #10
Message was sent while issue was closed.
Change committed as 213404

Powered by Google App Engine
This is Rietveld 408576698