We sometimes erroneously detected processes in other sessions as belonging to our session. Conseque…

We sometimes erroneously detected processes in other sessions
as belonging to our session. Consequently, we would terminate
these processes when our session shut down. We are now more
conservative about deleting processes when a session ends.

BUG=n/a
TEST=Start two instances of the same chroot (e.g. precise32) in two different shell windows. Terminate one of them. Notice that the other one is still running.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213049

[Markus (顧孟勤), 2013-07-23 00:28:08]

Julien, I think this fixes the issue that you ran into today.

We already tried to do the right thing, but it turns out the schroot script is
overly aggressive in sharing directories by means of bind mounts. It turns out,
while it does set up separate directories for each instance of the chroot (it
calls these sessions), there is no way to tell processes in one instance apart
from processes in another one.

[jln (very slow on Chromium), 2013-07-23 00:41:20]

lgtm

There is a lot of complicated bash magic in there, it would be nice to add some
comments!

https://codereview.chromium.org/20010003/diff/1/build/install-chroot.sh
File build/install-chroot.sh (right):

https://codereview.chromium.org/20010003/diff/1/build/install-chroot.sh#newco...
build/install-chroot.sh:515: pids=$({ ls -id1 /proc/*/root/. 2>/dev/null |
Add a comment to explain the set substraction magic here ?

[Markus (顧孟勤), 2013-07-23 00:54:36]

PTAL

[jln (very slow on Chromium), 2013-07-23 01:16:21]

lgtm, thanks for the fix!

[commit-bot: I haz the power, 2013-07-23 01:24:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markus@chromium.org/20010003/4001

[commit-bot: I haz the power, 2013-07-23 02:45:33]

Retried try job too often on linux_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-07-23 04:49:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markus@chromium.org/20010003/4001

[commit-bot: I haz the power, 2013-07-23 05:36:09]

Change committed as 213049