Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2000433002: Remove unused DataReductionProxyInfoBar and related code (Closed)

Created:
4 years, 7 months ago by megjablon
Modified:
4 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, dfalcantara+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused DataReductionProxyInfoBar and related code BUG=593068 Committed: https://crrev.com/8deb20c51c1ba007fee2929c07e9c11ac8d171a1 Cr-Commit-Position: refs/heads/master@{#395184}

Patch Set 1 #

Total comments: 2

Patch Set 2 : obsolete enum value #

Messages

Total messages: 17 (7 generated)
megjablon
dfalcantara: chrome/android/* sdefresne: infobar_delegate.h thestig: everything else PTAL, thanks!
4 years, 7 months ago (2016-05-19 23:06:16 UTC) #2
gone
lgtm
4 years, 7 months ago (2016-05-19 23:42:02 UTC) #4
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-19 23:43:43 UTC) #5
sdefresne
https://chromiumcodereview.appspot.com/2000433002/diff/1/components/infobars/core/infobar_delegate.h File components/infobars/core/infobar_delegate.h (right): https://chromiumcodereview.appspot.com/2000433002/diff/1/components/infobars/core/infobar_delegate.h#newcode64 components/infobars/core/infobar_delegate.h:64: // KEEP IN SYNC WITH THE InfoBarIdentifier ENUM IN ...
4 years, 7 months ago (2016-05-20 12:51:07 UTC) #6
megjablon
+asvitkine: histograms.xml https://chromiumcodereview.appspot.com/2000433002/diff/1/components/infobars/core/infobar_delegate.h File components/infobars/core/infobar_delegate.h (right): https://chromiumcodereview.appspot.com/2000433002/diff/1/components/infobars/core/infobar_delegate.h#newcode64 components/infobars/core/infobar_delegate.h:64: // KEEP IN SYNC WITH THE InfoBarIdentifier ...
4 years, 7 months ago (2016-05-20 18:52:14 UTC) #8
sdefresne
components/ lgtm
4 years, 7 months ago (2016-05-20 19:53:11 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-20 19:59:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000433002/20001
4 years, 7 months ago (2016-05-20 20:42:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 22:24:51 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 22:27:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8deb20c51c1ba007fee2929c07e9c11ac8d171a1
Cr-Commit-Position: refs/heads/master@{#395184}

Powered by Google App Engine
This is Rietveld 408576698