Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: chrome/browser/media_galleries/media_galleries_permissions_unittest.cc

Issue 20003005: Fix remaining leaks in StorageMonitorLinux. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "chrome/browser/extensions/extension_prefs.h" 6 #include "chrome/browser/extensions/extension_prefs.h"
7 #include "chrome/browser/extensions/extension_prefs_unittest.h" 7 #include "chrome/browser/extensions/extension_prefs_unittest.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/extensions/extension_system.h" 9 #include "chrome/browser/extensions/extension_system.h"
10 #include "chrome/browser/media_galleries/media_galleries_preferences.h" 10 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
(...skipping 10 matching lines...) Expand all
21 std::vector<MediaGalleryPermission>* vector) { 21 std::vector<MediaGalleryPermission>* vector) {
22 MediaGalleryPermission permission; 22 MediaGalleryPermission permission;
23 permission.pref_id = gallery; 23 permission.pref_id = gallery;
24 permission.has_permission = has_access; 24 permission.has_permission = has_access;
25 vector->push_back(permission); 25 vector->push_back(permission);
26 } 26 }
27 27
28 } // namespace 28 } // namespace
29 29
30 // Test the MediaGalleries permissions functions. 30 // Test the MediaGalleries permissions functions.
31 class MediaGalleriesPermissionsTest 31 class MediaGalleriesPermissionsTest : public extensions::ExtensionPrefsTest {
32 : public extensions::ExtensionPrefsTest {
33 protected: 32 protected:
34 MediaGalleriesPermissionsTest() 33 MediaGalleriesPermissionsTest() {}
35 : profile_(new TestingProfile), 34 virtual ~MediaGalleriesPermissionsTest() {}
36 gallery_prefs_(new MediaGalleriesPreferences(profile_.get())) {
37 gallery_prefs_->SetExtensionPrefsForTesting(prefs());
38 }
39
40 virtual ~MediaGalleriesPermissionsTest() {
41 }
42 35
43 // This is the same implementation as ExtensionPrefsTest::TearDown(), except 36 // This is the same implementation as ExtensionPrefsTest::TearDown(), except
44 // for also resetting the ExtensionPrefs used by |gallery_prefs_| after 37 // for also resetting the ExtensionPrefs used by |gallery_prefs_| after
45 // TestExtensionPrefs reconstructs them. 38 // TestExtensionPrefs reconstructs them.
46 virtual void TearDown() OVERRIDE { 39 virtual void TearDown() OVERRIDE {
47 Verify(); 40 Verify();
48 41
49 // Reset ExtensionPrefs, and re-verify. 42 // Reset ExtensionPrefs, and re-verify.
50 prefs_.ResetPrefRegistry(); 43 prefs_.ResetPrefRegistry();
51 RegisterPreferences(prefs_.pref_registry().get()); 44 RegisterPreferences(prefs_.pref_registry().get());
52 prefs_.RecreateExtensionPrefs(); 45 prefs_.RecreateExtensionPrefs();
53 gallery_prefs_->SetExtensionPrefsForTesting(prefs()); 46 gallery_prefs_->SetExtensionPrefsForTesting(prefs());
54 Verify(); 47 Verify();
55 prefs_.pref_service()->CommitPendingWrite(); 48 prefs_.pref_service()->CommitPendingWrite();
56 message_loop_.RunUntilIdle(); 49 message_loop_.RunUntilIdle();
57 50
58 testing::Test::TearDown(); 51 testing::Test::TearDown();
59 } 52 }
60 53
61 virtual void Initialize() OVERRIDE { 54 virtual void Initialize() OVERRIDE {
55 ASSERT_TRUE(test::TestStorageMonitor::CreateAndInstall());
56 profile_.reset(new TestingProfile);
57 gallery_prefs_.reset(new MediaGalleriesPreferences(profile_.get()));
58 gallery_prefs_->SetExtensionPrefsForTesting(prefs());
59
62 extension1_id_ = prefs_.AddExtensionAndReturnId("test1"); 60 extension1_id_ = prefs_.AddExtensionAndReturnId("test1");
63 extension2_id_ = prefs_.AddExtensionAndReturnId("test2"); 61 extension2_id_ = prefs_.AddExtensionAndReturnId("test2");
64 extension3_id_ = prefs_.AddExtensionAndReturnId("test3"); 62 extension3_id_ = prefs_.AddExtensionAndReturnId("test3");
65 // Id4 isn't used to ensure that an empty permission list is ok. 63 // Id4 isn't used to ensure that an empty permission list is ok.
66 extension4_id_ = prefs_.AddExtensionAndReturnId("test4"); 64 extension4_id_ = prefs_.AddExtensionAndReturnId("test4");
67 Verify(); 65 Verify();
68 66
69 gallery_prefs_->SetGalleryPermissionInPrefs(extension1_id_, 1, false); 67 gallery_prefs_->SetGalleryPermissionInPrefs(extension1_id_, 1, false);
70 AddGalleryPermission(1, false, &extension1_expectation_); 68 AddGalleryPermission(1, false, &extension1_expectation_);
71 Verify(); 69 Verify();
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 std::string extension1_id_; 127 std::string extension1_id_;
130 std::string extension2_id_; 128 std::string extension2_id_;
131 std::string extension3_id_; 129 std::string extension3_id_;
132 std::string extension4_id_; 130 std::string extension4_id_;
133 131
134 std::vector<MediaGalleryPermission> extension1_expectation_; 132 std::vector<MediaGalleryPermission> extension1_expectation_;
135 std::vector<MediaGalleryPermission> extension2_expectation_; 133 std::vector<MediaGalleryPermission> extension2_expectation_;
136 std::vector<MediaGalleryPermission> extension3_expectation_; 134 std::vector<MediaGalleryPermission> extension3_expectation_;
137 std::vector<MediaGalleryPermission> extension4_expectation_; 135 std::vector<MediaGalleryPermission> extension4_expectation_;
138 136
139 test::TestStorageMonitor monitor_;
140 scoped_ptr<TestingProfile> profile_; 137 scoped_ptr<TestingProfile> profile_;
141 scoped_ptr<MediaGalleriesPreferences> gallery_prefs_; 138 scoped_ptr<MediaGalleriesPreferences> gallery_prefs_;
142 }; 139 };
143 TEST_F(MediaGalleriesPermissionsTest, MediaGalleries) {} 140 TEST_F(MediaGalleriesPermissionsTest, MediaGalleries) {}
144 141
145 } // namespace chrome 142 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698