Fix remaining leaks in StorageMonitorLinux.

Fix remaining leaks in StorageMonitorLinux.

BUG=222687
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213850

[Lei Zhang, 2013-07-24 06:09:02]

There may be some other platform specific tests to fix up, but this is the
general direction for this CL.

[vandebo (ex-Chrome), 2013-07-24 14:42:59]

https://codereview.chromium.org/20003005/diff/14001/chrome/test/base/testing_...
File chrome/test/base/testing_browser_process.cc (left):

https://codereview.chromium.org/20003005/diff/14001/chrome/test/base/testing_...
chrome/test/base/testing_browser_process.cc:333:
chrome::test::TestStorageMonitor* monitor =
Why get rid of this, this is how a lot of things in TestingBrowserProcess works.

[Lei Zhang, 2013-07-24 21:04:48]

On 2013/07/24 14:42:59, vandebo wrote:
>
https://codereview.chromium.org/20003005/diff/14001/chrome/test/base/testing_...
> File chrome/test/base/testing_browser_process.cc (left):
> 
>
https://codereview.chromium.org/20003005/diff/14001/chrome/test/base/testing_...
> chrome/test/base/testing_browser_process.cc:333:
> chrome::test::TestStorageMonitor* monitor =
> Why get rid of this, this is how a lot of things in TestingBrowserProcess
works.

The real BrowserProcessImpl doesn't create it on demand, so neither should the
TestingBrowserProcess. If you look at the leak, destroying the
TestingStorageMonitor ends up triggering the creation of a new one:

528 (240 direct, 288 indirect) bytes in 1 blocks are definitely lost in loss
record 12,671 of 14,592
  operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140)
  TestingBrowserProcess::storage_monitor()
(/out/Debug/../../chrome/test/base/testing_browser_process.cc:334)
  chrome::StorageMonitor::GetInstance()
(/out/Debug/../../chrome/browser/storage_monitor/storage_monitor.cc:49)
  chrome::(anonymous namespace)::GetMediaTransferProtocolManager()
(/out/Debug/../../chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc:28)
 
chrome::MediaTransferProtocolDeviceObserverLinux::~MediaTransferProtocolDeviceObserverLinux()
(/out/Debug/../../chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc:152)
 
chrome::MediaTransferProtocolDeviceObserverLinux::~MediaTransferProtocolDeviceObserverLinux()
(/out/Debug/../../chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc:155)
 
base::DefaultDeleter<chrome::MediaTransferProtocolDeviceObserverLinux>::operator()(chrome::MediaTransferProtocolDeviceObserverLinux*)
const (/out/Debug/../../base/memory/scoped_ptr.h:137)
 
base::internal::scoped_ptr_impl<chrome::MediaTransferProtocolDeviceObserverLinux,
base::DefaultDeleter<chrome::MediaTransferProtocolDeviceObserverLinux>
>::~scoped_ptr_impl() (/out/Debug/../../base/memory/scoped_ptr.h:220)
  scoped_ptr<chrome::MediaTransferProtocolDeviceObserverLinux,
base::DefaultDeleter<chrome::MediaTransferProtocolDeviceObserverLinux>
>::~scoped_ptr() (/out/Debug/../../base/memory/scoped_ptr.h:310)
  chrome::StorageMonitorLinux::~StorageMonitorLinux()
(/out/Debug/../../chrome/browser/storage_monitor/storage_monitor_linux.cc:273)
  chrome::(anonymous
namespace)::TestStorageMonitorLinux::~TestStorageMonitorLinux()
(/out/Debug/../../chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc:135)
  chrome::(anonymous
namespace)::TestStorageMonitorLinux::~TestStorageMonitorLinux()
(/out/Debug/../../chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc:135)
 
base::DefaultDeleter<chrome::StorageMonitor>::operator()(chrome::StorageMonitor*)
const (/out/Debug/../../base/memory/scoped_ptr.h:137)
  base::internal::scoped_ptr_impl<chrome::StorageMonitor,
base::DefaultDeleter<chrome::StorageMonitor> >::reset(chrome::StorageMonitor*)
(/out/Debug/../../base/memory/scoped_ptr.h:246)
  scoped_ptr<chrome::StorageMonitor,
base::DefaultDeleter<chrome::StorageMonitor> >::reset(chrome::StorageMonitor*)
(/out/Debug/../../base/memory/scoped_ptr.h:367)
  TestingBrowserProcess::SetStorageMonitor(scoped_ptr<chrome::StorageMonitor,
base::DefaultDeleter<chrome::StorageMonitor> >)
(/out/Debug/../../chrome/test/base/testing_browser_process.cc:425)
  chrome::test::TestStorageMonitor::RemoveSingleton()
(/out/Debug/../../chrome/browser/storage_monitor/test_storage_monitor.cc:63)

[Lei Zhang, 2013-07-24 21:09:55]

+earthdok@ who mentioned the same problem in
http://code.google.com/p/chromium/issues/detail?id=222687#c18

[vandebo (ex-Chrome), 2013-07-24 21:13:00]

LGTM

[commit-bot: I haz the power, 2013-07-24 21:59:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/20003005/14001

[commit-bot: I haz the power, 2013-07-25 13:52:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/20003005/14001

[commit-bot: I haz the power, 2013-07-26 01:41:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/20003005/14001

[commit-bot: I haz the power, 2013-07-26 11:51:06]

Change committed as 213850