Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 20002008: Don't use Vector<UChar> to build strings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix unit test Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/SerializedScriptValue.cpp ('k') | Source/core/platform/graphics/Color.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSPrimitiveValue.cpp
diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp
index d7945afd044a92213dd1c0b10177ddca3787b2d2..602430b97a734f179e43de2bbf91dfee6fa457fc 100644
--- a/Source/core/css/CSSPrimitiveValue.cpp
+++ b/Source/core/css/CSSPrimitiveValue.cpp
@@ -1025,21 +1025,21 @@ String CSSPrimitiveValue::customCssText(CssTextFormattingFlags formattingFlag) c
Color::parseHexColor(m_value.string, rgbColor);
Color color(rgbColor);
- Vector<LChar> result;
- result.reserveInitialCapacity(32);
+ StringBuilder result;
+ result.reserveCapacity(32);
bool colorHasAlpha = color.hasAlpha();
if (colorHasAlpha)
result.append("rgba(", 5);
else
result.append("rgb(", 4);
- appendNumber(result, static_cast<unsigned char>(color.red()));
+ result.appendNumber(static_cast<unsigned char>(color.red()));
result.append(", ", 2);
- appendNumber(result, static_cast<unsigned char>(color.green()));
+ result.appendNumber(static_cast<unsigned char>(color.green()));
result.append(", ", 2);
- appendNumber(result, static_cast<unsigned char>(color.blue()));
+ result.appendNumber(static_cast<unsigned char>(color.blue()));
if (colorHasAlpha) {
result.append(", ", 2);
@@ -1049,7 +1049,7 @@ String CSSPrimitiveValue::customCssText(CssTextFormattingFlags formattingFlag) c
}
result.append(')');
- text = String::adopt(result);
+ text = result.toString();
break;
}
case CSS_PAIR:
« no previous file with comments | « Source/bindings/v8/SerializedScriptValue.cpp ('k') | Source/core/platform/graphics/Color.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698