Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 20002008: Don't use Vector<UChar> to build strings (Closed)

Created:
7 years, 5 months ago by abarth-chromium
Modified:
7 years, 5 months ago
Reviewers:
eseidel
CC:
blink-reviews, Nils Barth (inactive), jamesr, kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, danakj, marja+watch_chromium.org, dglazkov+blink, Rik, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, haraken, Stephen Chennney, Nate Chapin, jeez, pdr., do-not-use
Visibility:
Public.

Description

Don't use Vector<UChar> to build strings This CL removes a bunch of code sites that were using Vector<UChar> to construct strings. That used to be a good way to construct strings, but in the modern world, we have much better alternatives in the form of StringBuffer and StringBuilder. (You should use StringBuffer if you know exactly how much memory you need and you should use StringBuilder if you require a variable amount of memory.) This CL removes more clients of the StringImpl pointer. There are still a few left, which require more study. R=eseidel BUG=262320 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154843

Patch Set 1 #

Patch Set 2 : Fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M Source/bindings/v8/SerializedScriptValue.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/graphics/Color.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/platform/text/LocaleICU.cpp View 6 chunks +11 lines, -10 lines 0 comments Download
M Source/wtf/text/StringBuffer.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
abarth-chromium
7 years, 5 months ago (2013-07-23 22:15:36 UTC) #1
eseidel
lgtm
7 years, 5 months ago (2013-07-23 22:17:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20002008/1
7 years, 5 months ago (2013-07-23 22:17:21 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14374
7 years, 5 months ago (2013-07-24 00:47:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20002008/1
7 years, 5 months ago (2013-07-24 00:49:09 UTC) #5
commit-bot: I haz the power
Change committed as 154802
7 years, 5 months ago (2013-07-24 01:39:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20002008/17001
7 years, 5 months ago (2013-07-24 18:16:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=18276
7 years, 5 months ago (2013-07-24 19:22:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20002008/17001
7 years, 5 months ago (2013-07-24 19:22:42 UTC) #9
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
7 years, 5 months ago (2013-07-24 19:22:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20002008/17001
7 years, 5 months ago (2013-07-24 19:28:42 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 19:30:19 UTC) #12
Message was sent while issue was closed.
Change committed as 154843

Powered by Google App Engine
This is Rietveld 408576698