Issue 19997004: Correctly pass the issue number as "issue" parameter to Changelist ctor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19997004: Correctly pass the issue number as "issue" parameter to Changelist ctor (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Correctly pass the issue number as "issue" parameter to Changelist ctor Instead of as branchref. Because it's an issue. Not a branchref. Also, add myself as owner. BUG=none R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=213387

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	git_cl.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19997004/1

7 years, 5 months ago (2013-07-24 10:23:05 UTC) #3

Message was sent while issue was closed.

Change committed as 213387