Issue 19990007: Don't leak CopyResult textures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19990007: Don't leak CopyResult textures. (Closed)

Created:
7 years, 5 months ago by danakj

Modified:
7 years, 5 months ago

Reviewers:
piman

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't leak CopyResult textures. When a CopyResult provides a TextureMailbox, the ReleaseCallback must be called on the TextureMailbox when then client is done with the CopyResult. This change ensures that this happens. If the TextureMailbox is never removed from the CopyResult, then the CopyResult destructor takes care of it. Since the texture was never used, it uses a sync point of 0. When the TextureMailbox is removed from the CopyResult, then RWHVAura makes sure it calls the ReleaseCallback once it has the pixels it needs in memory. Since the pixels are already available on the CPU, it can use a sync point of 0 as well. R=piman BUG=263483 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213297

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	cc/output/copy_output_result.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		4 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/19990007/1

7 years, 5 months ago (2013-07-23 18:36:43 UTC) #3

Message was sent while issue was closed.

Change committed as 213297

Expand Messages | Collapse Messages