third_party/WebKit/Source/core/dom/StyleEngine.cpp - Issue 1998503002: CSS: Checked downcast for ShadowTreeStyleSheetCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/StyleEngine.cpp

Issue 1998503002: CSS: Checked downcast for ShadowTreeStyleSheetCollection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.h ('k') | third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/StyleEngine.cpp

diff --git a/third_party/WebKit/Source/core/dom/StyleEngine.cpp b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

index bf0ea0dc6fa95c8863be8c13b3be1fc163ad84f6..e90bb0502627dcab5c4fc5547b3f4f84c0fa5d42 100644

--- a/third_party/WebKit/Source/core/dom/StyleEngine.cpp

+++ b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

@@ -246,7 +246,7 @@ void StyleEngine::clearMediaQueryRuleSetOnTreeScopeStyleSheets(UnorderedTreeScop

{

for (TreeScope* treeScope : treeScopes) {

DCHECK(treeScope != m_document);

- ShadowTreeStyleSheetCollection* collection = static_cast<ShadowTreeStyleSheetCollection*>(styleSheetCollectionFor(*treeScope));

+ ShadowTreeStyleSheetCollection* collection = toShadowTreeStyleSheetCollection(styleSheetCollectionFor(*treeScope));

DCHECK(collection);

collection->clearMediaQueryRuleSetStyleSheets();

}

@@ -271,7 +271,7 @@ void StyleEngine::updateStyleSheetsInImport(DocumentStyleSheetCollector& parentC

void StyleEngine::updateActiveStyleSheetsInShadow(StyleResolverUpdateMode updateMode, TreeScope* treeScope, UnorderedTreeScopeSet& treeScopesRemoved)

{

DCHECK_NE(treeScope, m_document);

- ShadowTreeStyleSheetCollection* collection = static_cast<ShadowTreeStyleSheetCollection*>(styleSheetCollectionFor(*treeScope));

+ ShadowTreeStyleSheetCollection* collection = toShadowTreeStyleSheetCollection(styleSheetCollectionFor(*treeScope));

DCHECK(collection);

collection->updateActiveStyleSheets(*this, updateMode);

if (!collection->hasStyleSheetCandidateNodes()) {