Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: sync/sessions/sync_session.h

Issue 19982002: sync: Remove SyncSourceInfo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Convert SyncShareRecords to typedef Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/sessions/status_controller.h ('k') | sync/sessions/sync_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sessions/sync_session.h
diff --git a/sync/sessions/sync_session.h b/sync/sessions/sync_session.h
index 8f4e9edcd3d96f529763675b21be9a9fb012d6d6..cd4a22ccc19f40a6171fbdaeec3958aa912105a8 100644
--- a/sync/sessions/sync_session.h
+++ b/sync/sessions/sync_session.h
@@ -104,14 +104,18 @@ class SYNC_EXPORT_PRIVATE SyncSession {
// Build a session without a nudge tracker. Used for poll or configure type
// sync cycles.
static SyncSession* Build(SyncSessionContext* context,
- Delegate* delegate,
- const SyncSourceInfo& source);
+ Delegate* delegate);
~SyncSession();
// Builds a thread-safe and read-only copy of the current session state.
SyncSessionSnapshot TakeSnapshot() const;
+ SyncSessionSnapshot TakeSnapshotWithSource(
+ sync_pb::GetUpdatesCallerInfo::GetUpdatesSource legacy_updates_source)
+ const;
// Builds and sends a snapshot to the session context's listeners.
+ void SendSyncCycleEndEventNotification(
+ sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);
void SendEventNotification(SyncEngineEvent::EventCause cause);
// TODO(akalin): Split this into context() and mutable_context().
@@ -124,19 +128,12 @@ class SYNC_EXPORT_PRIVATE SyncSession {
return status_controller_.get();
}
- const SyncSourceInfo& source() const { return source_; }
-
private:
- SyncSession(SyncSessionContext* context,
- Delegate* delegate,
- const SyncSourceInfo& source);
+ SyncSession(SyncSessionContext* context, Delegate* delegate);
// The context for this session, guaranteed to outlive |this|.
SyncSessionContext* const context_;
- // The source for initiating this sync session.
- SyncSourceInfo source_;
-
// The delegate for this session, must never be NULL.
Delegate* const delegate_;
« no previous file with comments | « sync/sessions/status_controller.h ('k') | sync/sessions/sync_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698