Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 19981006: Android: fixes (again) bb_device_status_check. (Closed)

Created:
7 years, 5 months ago by bulach
Modified:
7 years, 5 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android: fixes (again) bb_device_status_check. Following crrev.com/213194, imei can be absent on some devices. BUG=254014 NOTRY=True TBR=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ptal
7 years, 5 months ago (2013-07-24 13:10:39 UTC) #1
tomhudson
lgtm Assuming re.findall() isn't going to die if sub_info is empty...
7 years, 5 months ago (2013-07-24 13:14:57 UTC) #2
bulach
it shouldn't be empty, otherwise the previous patch would've worked :) (famous last words... we'll ...
7 years, 5 months ago (2013-07-24 13:21:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/19981006/1
7 years, 5 months ago (2013-07-24 13:21:55 UTC) #4
commit-bot: I haz the power
Change committed as 213422
7 years, 5 months ago (2013-07-24 13:34:41 UTC) #5
navabi
On 2013/07/24 13:34:41, I haz the power (commit-bot) wrote: > Change committed as 213422 Thanks ...
7 years, 5 months ago (2013-07-24 16:28:12 UTC) #6
navabi
7 years, 5 months ago (2013-07-24 16:28:21 UTC) #7
Message was sent while issue was closed.
On 2013/07/24 16:28:12, navabi wrote:
> On 2013/07/24 13:34:41, I haz the power (commit-bot) wrote:
> > Change committed as 213422
> 
> Thanks Marcus. I had a similar CL (https://codereview.chromium.org/19599013/)
> that I will abandon in favor of this.

LGTM

Powered by Google App Engine
This is Rietveld 408576698