Issue 19980004: Web MIDI: add kDumpRenderTree flag check to ShellBrowserContext::RequestMIDI...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19980004: Web MIDI: add kDumpRenderTree flag check to ShellBrowserContext::RequestMIDI... (Closed)

Created:
7 years, 5 months ago by Takashi Toyoshima

Modified:
7 years, 5 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Web MIDI: add kDumpRenderTree flag check to ShellBrowserContext::RequestMIDI... content_shell should work with full features if it runs without the kDumpRenderTree flag. BUG=163795, 257618 TBR=jam@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213077

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3 lines)			Patch
M	chrome/browser/profiles/off_the_record_profile_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/shell_browser_context.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/19980004/1

7 years, 5 months ago (2013-07-23 10:01:41 UTC) #1

Takashi Toyoshima

based on comments after commit; https://codereview.chromium.org/18647002/

7 years, 5 months ago (2013-07-23 10:02:05 UTC) #2

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=151774

7 years, 5 months ago (2013-07-23 11:29:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/19980004/1

7 years, 5 months ago (2013-07-23 11:45:25 UTC) #4

Message was sent while issue was closed.

Change committed as 213077

Expand Messages | Collapse Messages